You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gashutos (via GitHub)" <gi...@apache.org> on 2023/05/25 20:31:45 UTC

[GitHub] [lucene] gashutos opened a new issue, #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present.

gashutos opened a new issue, #12333:
URL: https://github.com/apache/lucene/issues/12333

   ### Description
   
   If we specify ```after``` value for ```PagingFieldCollector``` which is out of min/max values for that field in that segment, ```PagingFieldCollector``` is not able to update its competitiveIterator because ```queueFull``` is never able to set to true.
   Code ref - [NumericComparator.java$194](https://github.com/apache/lucene/blob/c188d47a8b3b58748ec88335287da86582290c73/lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java#LL194C1-L194C7)
   
   Due to this, it will spend lot of time comparing large number of hits here [TopFieldCollector.java#264](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java#LL264C22-L264C22).
   Instead it is supposed to short cut right away.
   
   ### Version and environment details
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] gsmiller commented on issue #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present.

Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on issue #12333:
URL: https://github.com/apache/lucene/issues/12333#issuecomment-1571058983

   Thanks for the PR @gashutos! Merged and back-ported under 9.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] gsmiller closed issue #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present.

Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller closed issue #12333: PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present.
URL: https://github.com/apache/lucene/issues/12333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org