You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hong Tang (JIRA)" <ji...@apache.org> on 2009/07/31 10:04:14 UTC

[jira] Created: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
-------------------------------------------------------------------------------

                 Key: HADOOP-6173
                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
             Project: Hadoop Common
          Issue Type: Bug
          Components: build
    Affects Versions: 0.21.0
            Reporter: Hong Tang
            Priority: Minor


src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744999#action_12744999 ] 

Hong Tang commented on HADOOP-6173:
-----------------------------------

Could we move forward with this jira?

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6173:
-------------------------------------------

     Component/s:     (was: build)
                  scripts
    Hadoop Flags: [Reviewed]

+1 patch looks good

> ... And Cos created a new issue HADOOP-6174 to track the unit tests for scripts. ...
We are currently doing manual tests for scripts.  Could you post the manual test results and "Also please list what manual steps were performed to verify this patch"?

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: scripts
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737650#action_12737650 ] 

Hong Tang commented on HADOOP-6173:
-----------------------------------

Just to clarify, the current build.xml behavior seems to be incorrect/inconsistent with what you described. If I put in a 3rd party jar in lib/, it will be copied to release tar, and if I put a 3rd party native library under lib/native with "hadoop" in their names (like libhadoopgplcompression.so), they will also be included.

So I would argue that it is reasonable to include all jars and native libraries under lib/ to tar ball for two reasons:
- it is a user's conscience decision to copy data under lib/ and thus the inclusion of these files is "by-choice".
- the hadoop script currently includes all jars under lib/ in classpath, and all native libraries under lib/native/<arch>/ in sysproperty java.library.path. And it is reasonable for user to expect that if he/she runs an "ant tar" and untar the tarball somewhere else, it should behave exactly the same as the original place.

I am fine to add a test to verify the behavior. How about just running md5sum over the set of files under lib and under package final destination?

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6173:
-------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Hong!

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build, scripts
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745845#action_12745845 ] 

Hudson commented on HADOOP-6173:
--------------------------------

Integrated in Hadoop-Common-trunk #63 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/63/])
    . Change src/native/packageNativeHadoop.sh to package all native library files.  Contributed by Hong Tang


> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build, scripts
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-6173:
---------------------------------

    Issue Type: New Feature  (was: Bug)

This seems to me more like a new feature request than a bug: existing code is designed to package what's to be included in a release and no more.  You'd like to extend the package task to support inclusion of third party binaries.  If we intend to maintain support for such a feature, should we add a test for it?

Alternately you might be able to layer your own Ant build file that imports Hadoop's build.xml has a task that depends on the "package" target that then copies extra things into the dist directory, then a task that depends on that task and the "tar" task to bundle everything up.


> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745133#action_12745133 ] 

Hadoop QA commented on HADOOP-6173:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12415106/hadoop-6174-20090731.patch
  against trunk revision 804918.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/614/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/614/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/614/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/614/console

This message is automatically generated.

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737457#action_12737457 ] 

Hong Tang commented on HADOOP-6173:
-----------------------------------

The context of the problem is that I want to write a external script to package jars and native libraries from hadoop-gpl-compression to hadoop trunk tarball. The brief procedure is as follows:
- build hadoop-gpl-compression, put jar file under $hadoop-src-dir/lib, and native libraries under $hadoop-src-dir/lib/native.
- run "ant tar" under $hadoop-src-dir.

However, in the tarball, hadoop-gpl-compression-0.1.0-dev.jar is included, but none of the native libraries are included (libgplcompression.*).

Close examination reveals that it is because the script src/native/packageNativeHadoop.sh has the following lines:
Line  45     $TAR *hadoop* | (cd $DIST_LIB_DIR/$platform/; $UNTAR)
Line  61     $TAR *hadoop* | (cd $DIST_LIB_DIR/$platform/; $UNTAR)

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Priority: Minor
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737731#action_12737731 ] 

Hong Tang commented on HADOOP-6173:
-----------------------------------

BTW, the attached patch file name is misleading (I mistyped).

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated HADOOP-6173:
------------------------------

    Fix Version/s: 0.21.0
           Status: Open  (was: Patch Available)

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745260#action_12745260 ] 

Hong Tang commented on HADOOP-6173:
-----------------------------------

Thanks Nicolas. I verified the patch through manual testing. Steps are listed as follows:

Step 0: download hadoop-gpl-compression source repository and build jar files and native library.
Step 1: copied hadoop-gpl-compression/build/hadoop-gpl-compression-0.1.0-dev/hadoop-gpl-compression-0.1.0-dev.jar  => hadoop-common/lib; hadoop-gpl-compression/build/hadoop-gpl-compression-0.1.0-dev/lib/native/* => hadoop-common/lib/native
Step 2: under hadoop-common, do "ant tar"
Step 3: tar -tzf hadoop-common/build/hadoop-core-0.21.0-dev.tar.gz | grep libgplcompression => returning nothing
Step 4: apply the patch, and redo steps 2-3, and grep shows libgplcompression.* are included in the tar


> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: scripts
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated HADOOP-6173:
------------------------------

    Attachment: hadoop-6174-20090731.patch

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated HADOOP-6173:
------------------------------

    Status: Patch Available  (was: Open)

resubmit patch for hudson

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang reassigned HADOOP-6173:
---------------------------------

    Assignee: Hong Tang

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6173:
-------------------------------------------

    Component/s: build

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build, scripts
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737730#action_12737730 ] 

Hong Tang commented on HADOOP-6173:
-----------------------------------

Looks like we need some basic support to test the scripts, particularly because the verification must be done after running "tar" or "package". Similar situation happens for HADOOP-6172. And Cos created a new issue HADOOP-6174 to track the unit tests for scripts. Could we resolve this issue for now?

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6173) src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated HADOOP-6173:
------------------------------

    Status: Patch Available  (was: Open)

Trivial patch that relaxes the file name restriction.

> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6173
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6173
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Priority: Minor
>         Attachments: hadoop-6174-20090731.patch
>
>
> src/native/packageNativeHadoop.sh only packages files with "hadoop" in the name. This becomes too restrictive when a user wants to inject third-party native libraries into his/her own tar build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.