You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2005/02/01 08:23:17 UTC

[jira] Updated: (MPECLIPSE-69) Make plugin work better "out of the box"

The following issue has been updated:

    Updater: Chad Woolley (mailto:thewoolleyman@gmail.com)
       Date: Tue, 1 Feb 2005 2:21 AM
    Changes:
             Attachment changed to maven_eclipse_plugin_patch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPECLIPSE-69?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-69

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-69
    Summary: Make plugin work better "out of the box"
       Type: Improvement

     Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin
   Fix Fors:
             1.9
   Versions:
             1.9

   Assignee: 
   Reporter: Chad Woolley

    Created: Tue, 1 Feb 2005 2:21 AM
    Updated: Tue, 1 Feb 2005 2:21 AM

Description:
Hi,

Attached is a patch which makes the following changes to the eclipse:external-tools-21 goal:

1. Makes default action to run goal against project.xml in the current project.
2. Makes default to refresh project containing the selected resource
3. Removes code to add each entry to favorites list, because they fill up the list and makes user have to scroll to see the bottom of the external tools menu.

I think these would be much more intuitive and convenient defaults for the majority of the plugin users.

Thanks,
Chad

Index: eclipse/src/plugin-resources/templates/launch.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/eclipse/src/plugin-resources/templates/launch.jelly,v
retrieving revision 1.4
diff -u -r1.4 launch.jelly
--- eclipse/src/plugin-resources/templates/launch.jelly	4 Mar 2004 18:04:37 -0000	1.4
+++ eclipse/src/plugin-resources/templates/launch.jelly	1 Feb 2005 06:55:58 -0000
@@ -19,13 +19,17 @@
 
 <launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
     <stringAttribute
-        key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-e -p $${resource_name} ${goal}"/>
+        key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-e -p project.xml ${goal}"/>
     <stringAttribute
         key="org.eclipse.ui.externaltools.ATTR_REFRESH_SCOPE" value="$${project}"/>
+    <stringAttribute
+        key="org.eclipse.debug.core.ATTR_REFRESH_SCOPE" value="$${project}"/>
+    <!-- don't add favorites, they overfill the menu
     <listAttribute key="org.eclipse.debug.ui.favoriteGroups">
         <listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
     </listAttribute>
+    -->
     <stringAttribute
-        key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="$${container_loc}"/>
+        key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="$${project_loc}"/>
     <stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${tool.loc}"/>
 </launchConfiguration>






---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org