You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/02 07:39:32 UTC
[GitHub] [cordova-lib] dpogue opened a new pull request #835: GH-832: Look at devDeps for restoring platforms
dpogue opened a new pull request #835:
URL: https://github.com/apache/cordova-lib/pull/835
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
N/A
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Closes #832 where the `cordova prepare` restore process would not look at package.json devDependencies for platforms, and would restore platforms with the wrong versions.
### Description
<!-- Describe your changes in detail -->
Make the platform restore process match the plugin restore process where both devDependencies and dependencies are taken into account.
This also includes fixes for writing package.json with the correct newlines, which should address the complaints raised in https://github.com/apache/cordova-cli/issues/353 and possibly https://github.com/apache/cordova-lib/issues/694.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Unit tests pass
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter commented on pull request #835: GH-832: Look at devDeps for restoring platforms
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #835:
URL: https://github.com/apache/cordova-lib/pull/835#issuecomment-637827293
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=h1) Report
> Merging [#835](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/7a20be8b67ee221e5e7c637ee1a7a18338619d76&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `91.30%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 89.96% 89.89% -0.08%
==========================================
Files 46 46
Lines 2133 2097 -36
==========================================
- Hits 1919 1885 -34
+ Misses 214 212 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/util/promise-util.js](https://codecov.io/gh/apache/cordova-lib/pull/835/diff?src=pr&el=tree#diff-c3JjL3V0aWwvcHJvbWlzZS11dGlsLmpz) | `100.00% <ø> (+16.66%)` | :arrow_up: |
| [src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/835/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz) | `92.50% <91.30%> (-1.46%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=footer). Last update [7a20be8...72d7807](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter edited a comment on pull request #835: GH-832: Look at devDeps for restoring platforms
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #835:
URL: https://github.com/apache/cordova-lib/pull/835#issuecomment-637827293
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=h1) Report
> Merging [#835](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/7a20be8b67ee221e5e7c637ee1a7a18338619d76&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `91.30%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 89.96% 89.89% -0.08%
==========================================
Files 46 46
Lines 2133 2097 -36
==========================================
- Hits 1919 1885 -34
+ Misses 214 212 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/util/promise-util.js](https://codecov.io/gh/apache/cordova-lib/pull/835/diff?src=pr&el=tree#diff-c3JjL3V0aWwvcHJvbWlzZS11dGlsLmpz) | `100.00% <ø> (+16.66%)` | :arrow_up: |
| [src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/835/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz) | `92.50% <91.30%> (-1.46%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=footer). Last update [7a20be8...72d7807](https://codecov.io/gh/apache/cordova-lib/pull/835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] erisu merged pull request #835: GH-832: Look at devDeps for restoring platforms
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #835:
URL: https://github.com/apache/cordova-lib/pull/835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org