You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/08/14 07:14:02 UTC

[GitHub] nkurihar commented on issue #671: Should authParamsString for Authentication support another format ?

nkurihar commented on issue #671: Should authParamsString for Authentication support another format ?
URL: https://github.com/apache/incubator-pulsar/issues/671#issuecomment-322115908
 
 
   @maskit 
   > I think the entire parameter value should be parsed on plugins side. Then plugins can choose any format they want. 
   
   Thank you for your comments and I agree.
   Then, how about modifying by 2 steps?
   
   Step 1.
   Add URL-decoding logic to C++ Athenz plugin (Morespecifically, ZTSClient.cc):
   https://github.com/apache/incubator-pulsar/blob/master/pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc#L76
   This change keeps the compatibility.
   
   Step 2.
   Move parsing logic from `AuthenticationFactory` to each Authentication plugin.
   https://github.com/apache/incubator-pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/api/AuthenticationFactory.java#L44-L53
   This change breaks the compatibility.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services