[GitHub] [flink-connector-hbase] zentol commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Fix hbase-client 2.2 dependency handling

[GitBox <gi...@apache.org>]

zentol commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1043332959


##########
flink-connector-hbase-2.2/pom.xml:
##########
@@ -152,6 +148,18 @@ under the License.
 					<groupId>org.apache.hadoop</groupId>
 					<artifactId>hadoop-hdfs</artifactId>
 				</exclusion>
+				<exclusion>
+					<groupId>org.apache.commons</groupId>
+					<artifactId>commons-lang3</artifactId>
+				</exclusion>
+				<exclusion>
+					<groupId>commons-io</groupId>
+					<artifactId>commons-io</artifactId>
+				</exclusion>
+				<exclusion>
+					<groupId>org.jruby.jcodings</groupId>
+					<artifactId>jcodings</artifactId>
+				</exclusion>

Review Comment:
   I'm assuming we don't know why these are excluded?
   



##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
@@ -39,15 +39,19 @@ under the License.
 			<groupId>org.apache.flink</groupId>
 			<artifactId>flink-connector-hbase-2.2</artifactId>
 			<version>${project.version}</version>
-			<exclusions>
-				<exclusion>
-					<groupId>org.apache.hbase</groupId>
-					<artifactId>hbase-client</artifactId>
-				</exclusion>
-			</exclusions>
 		</dependency>
 	</dependencies>
 
+	<dependencyManagement>
+		<dependencies>
+			<dependency>
+				<groupId>org.apache.hbase</groupId>
+				<artifactId>hbase-client</artifactId>
+				<version>${hbase2.version}</version>
+			</dependency>

Review Comment:
   This entry shouldn't be necessary since `flink-connector-hbase-2.2` already sets the version to `hbase2.version`.
   If it didn't we'd have bigger issues, because that'd mean users would have to do the same thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org