You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Nick Kew <ni...@apache.org> on 2011/12/16 11:19:11 UTC
Pre-apache code history
I'm trying to dig through the history of a section of TS code
to try and figure out the motivation for introducing it, and
hence the implications of hacking it. But svn annotate shows
the whole section goes back to svn r831143, the initial commit
of trafficserver to ASF repos.
Is there any publically-visible pre-apache code history?
--
Nick Kew
Re: Pre-apache code history
Posted by Bryan Call <bc...@yahoo-inc.com>.
Most code has undiscovered security problems. It is much easier to find them if you have all the code. I am unaware of Coverity actually finding a real problem in the code. It would have taken a lot longer to investigate each issue instead of just fixing the code.
On the flip side once you find a security problem or some else finds it for you, you can fix them...
-Bryan
On Dec 16, 2011, at 11:47 AM, Igor Galić wrote:
>
>
> ----- Original Message -----
>> Licensing issues and proprietary code like Miles said.
>>
>> We also went through a long security cleanup of the code. We ran
>> Coverity over the code and fix things it complained about even if it
>> might have been a false positive. We still run the 2+ year old
>> version in production that might still have security problems.
>
> You are writing this to a public mailing list ;)
>
>> -Bryan
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
>
Re: Pre-apache code history
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> Licensing issues and proprietary code like Miles said.
>
> We also went through a long security cleanup of the code. We ran
> Coverity over the code and fix things it complained about even if it
> might have been a false positive. We still run the 2+ year old
> version in production that might still have security problems.
You are writing this to a public mailing list ;)
> -Bryan
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: Pre-apache code history
Posted by Bryan Call <bc...@yahoo-inc.com>.
Licensing issues and proprietary code like Miles said.
We also went through a long security cleanup of the code. We ran Coverity over the code and fix things it complained about even if it might have been a false positive. We still run the 2+ year old version in production that might still have security problems.
-Bryan
On Dec 16, 2011, at 10:01 AM, Igor Galić wrote:
>
>
> ----- Original Message -----
>> It is not public, but I do have access to it all back to when we got
>> it from Inktomi. I don't have access to history for when it was
>> being developed at Inktomi.
>
> Is there a reason why the history hasn't been migrated to Apache?
>
>> Is there something in particular you want me to look for?
>>
>> -Bryan
>>
>> On Dec 16, 2011, at 2:19 AM, Nick Kew wrote:
>>
>>> I'm trying to dig through the history of a section of TS code
>>> to try and figure out the motivation for introducing it, and
>>> hence the implications of hacking it. But svn annotate shows
>>> the whole section goes back to svn r831143, the initial commit
>>> of trafficserver to ASF repos.
>>>
>>> Is there any publically-visible pre-apache code history?
>>>
>>> --
>>> Nick Kew
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
>
Re: Pre-apache code history
Posted by Jason Giedymin <ja...@gmail.com>.
Yeah the code was 'cleansed' prior to donation.
-Jason
On Dec 16, 2011, at 1:19 PM, Miles Libbey <ml...@yahoo.com> wrote:
> Yes-- it contained code that yahoo did not wish to contribute and, as a formerly commercial product, licensed 3rd party code that was not yahoo's to contribute.
> Miles
>
> On Dec 16, 2011, at 10:01 AM, Igor Galić <i....@brainsware.org> wrote:
>
>>
>>
>> ----- Original Message -----
>>> It is not public, but I do have access to it all back to when we got
>>> it from Inktomi. I don't have access to history for when it was
>>> being developed at Inktomi.
>>
>> Is there a reason why the history hasn't been migrated to Apache?
>>
>>> Is there something in particular you want me to look for?
>>>
>>> -Bryan
>>>
>>> On Dec 16, 2011, at 2:19 AM, Nick Kew wrote:
>>>
>>>> I'm trying to dig through the history of a section of TS code
>>>> to try and figure out the motivation for introducing it, and
>>>> hence the implications of hacking it. But svn annotate shows
>>>> the whole section goes back to svn r831143, the initial commit
>>>> of trafficserver to ASF repos.
>>>>
>>>> Is there any publically-visible pre-apache code history?
>>>>
>>>> --
>>>> Nick Kew
>>
>> i
>>
>> --
>> Igor Galić
>>
>> Tel: +43 (0) 664 886 22 883
>> Mail: i.galic@brainsware.org
>> URL: http://brainsware.org/
>> GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
>>
Re: Pre-apache code history
Posted by Miles Libbey <ml...@yahoo.com>.
Yes-- it contained code that yahoo did not wish to contribute and, as a formerly commercial product, licensed 3rd party code that was not yahoo's to contribute.
Miles
On Dec 16, 2011, at 10:01 AM, Igor Galić <i....@brainsware.org> wrote:
>
>
> ----- Original Message -----
>> It is not public, but I do have access to it all back to when we got
>> it from Inktomi. I don't have access to history for when it was
>> being developed at Inktomi.
>
> Is there a reason why the history hasn't been migrated to Apache?
>
>> Is there something in particular you want me to look for?
>>
>> -Bryan
>>
>> On Dec 16, 2011, at 2:19 AM, Nick Kew wrote:
>>
>>> I'm trying to dig through the history of a section of TS code
>>> to try and figure out the motivation for introducing it, and
>>> hence the implications of hacking it. But svn annotate shows
>>> the whole section goes back to svn r831143, the initial commit
>>> of trafficserver to ASF repos.
>>>
>>> Is there any publically-visible pre-apache code history?
>>>
>>> --
>>> Nick Kew
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
>
Re: Pre-apache code history
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> It is not public, but I do have access to it all back to when we got
> it from Inktomi. I don't have access to history for when it was
> being developed at Inktomi.
Is there a reason why the history hasn't been migrated to Apache?
> Is there something in particular you want me to look for?
>
> -Bryan
>
> On Dec 16, 2011, at 2:19 AM, Nick Kew wrote:
>
> > I'm trying to dig through the history of a section of TS code
> > to try and figure out the motivation for introducing it, and
> > hence the implications of hacking it. But svn annotate shows
> > the whole section goes back to svn r831143, the initial commit
> > of trafficserver to ASF repos.
> >
> > Is there any publically-visible pre-apache code history?
> >
> > --
> > Nick Kew
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: Pre-apache code history
Posted by Bryan Call <bc...@yahoo-inc.com>.
It is not public, but I do have access to it all back to when we got it from Inktomi. I don't have access to history for when it was being developed at Inktomi.
Is there something in particular you want me to look for?
-Bryan
On Dec 16, 2011, at 2:19 AM, Nick Kew wrote:
> I'm trying to dig through the history of a section of TS code
> to try and figure out the motivation for introducing it, and
> hence the implications of hacking it. But svn annotate shows
> the whole section goes back to svn r831143, the initial commit
> of trafficserver to ASF repos.
>
> Is there any publically-visible pre-apache code history?
>
> --
> Nick Kew