You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/11/05 03:48:35 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
zuston opened a new issue, #299:
URL: https://github.com/apache/incubator-uniffle/issues/299
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
Make config type of `RSS_STORAGE_TYPE` in `RssBaseConf` as enum
### How should we improve?
The enum type of config option is introduced in #199, follow this PR to fix the storage type config
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] selectbook commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
selectbook commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1308986122
is it change to something like this?
`public static final ConfigOption<StorageType> RSS_STORAGE_TYPE = ConfigOptions
.key("rss.storage.type")
.enumType(StorageType.class)
.noDefaultValue()
.withDescription("Data storage for remote shuffle service");
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] selectbook commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
selectbook commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1308991825
is it change to something like this?
`public static final ConfigOption<StorageType> RSS_STORAGE_TYPE = ConfigOptions`
`.key("rss.storage.type")`
`.enumType(StorageType.class)`
`.noDefaultValue()`
`.withDescription("Data storage for remote shuffle service");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] amaliujia commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1309558877
I looked this a bit. I thought this requires a good amount of refactoring. For example you might need to move `StorageType.class` to `common` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston closed issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
URL: https://github.com/apache/incubator-uniffle/issues/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1309027871
> is it change to something like this?
>
> public static final ConfigOption RSS_STORAGE_TYPE = ConfigOptions .key("rss.storage.type") .enumType(StorageType.class) .noDefaultValue() .withDescription("Data storage for remote shuffle service");
Yes, do you want to submit a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] selectbook commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
selectbook commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1309046144
> > is it change to something like this?
> > public static final ConfigOption RSS_STORAGE_TYPE = ConfigOptions .key("rss.storage.type") .enumType(StorageType.class) .noDefaultValue() .withDescription("Data storage for remote shuffle service");
>
> Yes, do you want to submit a PR?
yes i will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] selectbook commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
selectbook commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1308993743
is it change to something like this?
public static final ConfigOption<StorageType> RSS_STORAGE_TYPE = ConfigOptions
.key("rss.storage.type")
.enumType(StorageType.class)
.noDefaultValue()
.withDescription("Data storage for remote shuffle service");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] selectbook commented on issue #299: [Improvement] Make config type of RSS_STORAGE_TYPE as enum
Posted by GitBox <gi...@apache.org>.
selectbook commented on issue #299:
URL: https://github.com/apache/incubator-uniffle/issues/299#issuecomment-1308979771
is it change to like this?
`public static final ConfigOption<StorageType> RSS_STORAGE_TYPE = ConfigOptions
.key("rss.storage.type")
.enumType(StorageType.class)
.noDefaultValue()
.withDescription("Data storage for remote shuffle service");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org