You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2024/11/03 07:58:17 UTC

[PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

FrankYang0529 opened a new pull request, #17673:
URL: https://github.com/apache/kafka/pull/17673

   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17673:
URL: https://github.com/apache/kafka/pull/17673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835576053


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
             self.zk.start()
 
     @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)
-    @cluster(num_nodes=5)
+    @parametrize(version=str(LATEST_2_1), new_consumer=False)
     @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)

Review Comment:
   New result:
   
   ```
   > TC_PATHS="tests/kafkatest/sanity_checks/test_performance_services.py" /bin/bash tests/docker/run_tests.sh
   ================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2024-11-09--008
   run time:         2 minutes 45.572 seconds
   tests run:        6
   passed:           6
   flaky:            0
   failed:           0
   ignored:          0
   ================================================================================
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835570270


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
             self.zk.start()
 
     @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)
-    @cluster(num_nodes=5)
+    @parametrize(version=str(LATEST_2_1), new_consumer=False)
     @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)

Review Comment:
   @chia7712, I found the root cause. In 2.1.1, we still use broker-list, not bootstrap-server.
   
   https://github.com/apache/kafka/blob/21234bee31165527859b46ea48c46b76532f7a37/core/src/main/scala/kafka/tools/ConsumerPerformance.scala#L209-L212



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835576053


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
             self.zk.start()
 
     @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)
-    @cluster(num_nodes=5)
+    @parametrize(version=str(LATEST_2_1), new_consumer=False)
     @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)

Review Comment:
   New result:
   
   ```
   ================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2024-11-09--008
   run time:         2 minutes 45.572 seconds
   tests run:        6
   passed:           6
   flaky:            0
   failed:           0
   ignored:          0
   ================================================================================
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835137974


##########
tests/docker/Dockerfile:
##########
@@ -77,15 +77,6 @@ RUN echo 'PermitUserEnvironment yes' >> /etc/ssh/sshd_config
 # Install binary test dependencies.
 # we use the same versions as in vagrant/base.sh
 ARG KAFKA_MIRROR="https://s3-us-west-2.amazonaws.com/kafka-packages"
-RUN mkdir -p "/opt/kafka-0.8.2.2" && chmod a+rw /opt/kafka-0.8.2.2 && curl -s "$KAFKA_MIRROR/kafka_2.11-0.8.2.2.tgz" | tar xz --strip-components=1 -C "/opt/kafka-0.8.2.2"

Review Comment:
   Could you please remove old kafak from `base.sh` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835568028


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
             self.zk.start()
 
     @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)
-    @cluster(num_nodes=5)
+    @parametrize(version=str(LATEST_2_1), new_consumer=False)
     @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)

Review Comment:
   I tried to update it, but it looks like `LATEST_2_1` can't pass for this case:
   
   ```
   ================================================================================
   SESSION REPORT (ALL TESTS)
   ducktape version: 0.12.0
   session_id:       2024-11-09--005
   run time:         3 minutes 6.672 seconds
   tests run:        6
   passed:           3
   flaky:            0
   failed:           3
   ignored:          0
   ================================================================================
   test_id:    kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=2.1.1.metadata_quorum=COMBINED_KRAFT
   status:     FAIL
   run time:   31.068 seconds
   
   
       TypeError("'NoneType' object is not subscriptable")
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 351, in _do_run
       data = self.run_test()
     File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.7/dist-packages/ducktape/mark/_mark.py", line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File "/opt/kafka-dev/tests/kafkatest/sanity_checks/test_performance_services.py", line 80, in test_version
       consumer_perf_data = compute_aggregate_throughput(self.consumer_perf)
     File "/opt/kafka-dev/tests/kafkatest/services/performance/performance.py", line 69, in compute_aggregate_throughput
       aggregate_rate = sum([r['records_per_sec'] for r in perf.results])
     File "/opt/kafka-dev/tests/kafkatest/services/performance/performance.py", line 69, in <listcomp>
       aggregate_rate = sum([r['records_per_sec'] for r in perf.results])
   TypeError: 'NoneType' object is not subscriptable
   
   --------------------------------------------------------------------------------
   test_id:    kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=2.1.1.metadata_quorum=ISOLATED_KRAFT
   status:     FAIL
   run time:   39.534 seconds
   
   
       TypeError("'NoneType' object is not subscriptable")
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 351, in _do_run
       data = self.run_test()
     File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.7/dist-packages/ducktape/mark/_mark.py", line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File "/opt/kafka-dev/tests/kafkatest/sanity_checks/test_performance_services.py", line 80, in test_version
       consumer_perf_data = compute_aggregate_throughput(self.consumer_perf)
     File "/opt/kafka-dev/tests/kafkatest/services/performance/performance.py", line 69, in compute_aggregate_throughput
       aggregate_rate = sum([r['records_per_sec'] for r in perf.results])
     File "/opt/kafka-dev/tests/kafkatest/services/performance/performance.py", line 69, in <listcomp>
       aggregate_rate = sum([r['records_per_sec'] for r in perf.results])
   TypeError: 'NoneType' object is not subscriptable
   
   --------------------------------------------------------------------------------
   test_id:    kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=2.1.1.metadata_quorum=ZK
   status:     FAIL
   run time:   34.182 seconds
   
   
       TypeError("'NoneType' object is not subscriptable")
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 351, in _do_run
       data = self.run_test()
     File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 411, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.7/dist-packages/ducktape/mark/_mark.py", line 438, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File "/opt/kafka-dev/tests/kafkatest/sanity_checks/test_performance_services.py", line 80, in test_version
       consumer_perf_data = compute_aggregate_throughput(self.consumer_perf)
     File "/opt/kafka-dev/tests/kafkatest/services/performance/performance.py", line 69, in compute_aggregate_throughput
       aggregate_rate = sum([r['records_per_sec'] for r in perf.results])
     File "/opt/kafka-dev/tests/kafkatest/services/performance/performance.py", line 69, in <listcomp>
       aggregate_rate = sum([r['records_per_sec'] for r in perf.results])
   TypeError: 'NoneType' object is not subscriptable
   
   --------------------------------------------------------------------------------
   test_id:    kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=COMBINED_KRAFT
   status:     PASS
   run time:   24.350 seconds
   {"producer_performance": {"records_per_sec": 35971.2, "mb_per_sec": 3.43}, "end_to_end_latency": {"latency_50th_ms": 0.0, "latency_99th_ms": 1.0, "latency_999th_ms": 3.0}, "consumer_performance": {"records_per_sec": 30091.954, "mb_per_sec": 2.7676}}
   --------------------------------------------------------------------------------
   test_id:    kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=ISOLATED_KRAFT
   status:     PASS
   run time:   29.257 seconds
   {"producer_performance": {"records_per_sec": 33898.3, "mb_per_sec": 3.23}, "end_to_end_latency": {"latency_50th_ms": 0.0, "latency_99th_ms": 1.0, "latency_999th_ms": 3.0}, "consumer_performance": {"records_per_sec": 31829.7872, "mb_per_sec": 2.9274}}
   --------------------------------------------------------------------------------
   test_id:    kafkatest.sanity_checks.test_performance_services.PerformanceServiceTest.test_version.version=dev.metadata_quorum=ZK
   status:     PASS
   run time:   27.490 seconds
   {"producer_performance": {"records_per_sec": 32362.5, "mb_per_sec": 3.09}, "end_to_end_latency": {"latency_50th_ms": 0.0, "latency_99th_ms": 1.0, "latency_999th_ms": 4.0}, "consumer_performance": {"records_per_sec": 30265.896, "mb_per_sec": 2.7836}}
   --------------------------------------------------------------------------------
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835508337


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
             self.zk.start()
 
     @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)
-    @cluster(num_nodes=5)
+    @parametrize(version=str(LATEST_2_1), new_consumer=False)
     @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)

Review Comment:
   Could you please use `@matrix(version=[str(LATEST_2_1), str(DEV_BRANCH)], metadata_quorum=quorum.all)` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835561960


##########
tests/kafkatest/services/performance/consumer_performance.py:
##########
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic, messages, version=DEV_BRANC
         assert version.consumer_supports_bootstrap_server() or (not new_consumer), \
             "new_consumer is only supported if version >= 0.9.0.0, version %s" % str(version)
 
-        assert version < V_2_0_0 or new_consumer, \

Review Comment:
   Hi @chia7712, thanks for the suggestion. I'm curious whether we can assume `new_consumer` is always `true` in `ConsoleConsumer`? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1834649947


##########
tests/kafkatest/sanity_checks/test_verifiable_producer.py:
##########
@@ -91,10 +87,7 @@ def test_simple_run(self, producer_version, acks=None, enable_idempotence=False,
         # the time it takes the producer to produce its messages.

Review Comment:
   those comments are out-of-date after removing the 0.8.2, right?



##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -37,16 +37,9 @@ def setUp(self):
         if self.zk:
             self.zk.start()
 
-    @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)

Review Comment:
   we should keep one test suit for `LATEST_2_1` with old consumer



##########
tests/kafkatest/services/console_consumer.py:
##########
@@ -209,16 +193,14 @@ def start_cmd(self, node):
             cmd += " --property print.partition=true"
 
         # LoggingMessageFormatter was introduced after 0.9
-        if node.version > LATEST_0_9:
-            if node.version > LATEST_3_7:
-                cmd += " --formatter org.apache.kafka.tools.consumer.LoggingMessageFormatter"
-            else:
-                cmd += " --formatter kafka.tools.LoggingMessageFormatter"
+        if node.version > LATEST_3_7:
+            cmd += " --formatter org.apache.kafka.tools.consumer.LoggingMessageFormatter"
+        else:
+            cmd += " --formatter kafka.tools.LoggingMessageFormatter"
 
         if self.enable_systest_events:
             # enable systest events is only available in 0.10.0 and later

Review Comment:
   those comments are unused now, right?



##########
tests/kafkatest/version.py:
##########
@@ -72,10 +72,10 @@ def consumer_supports_bootstrap_server(self):
 
         :return: true if the version of Kafka supports a new consumer with --bootstrap-server
         """
-        return self >= V_0_9_0_0
+        return True

Review Comment:
   we don't need `consumer_supports_bootstrap_server`, right?



##########
tests/kafkatest/version.py:
##########
@@ -72,10 +72,10 @@ def consumer_supports_bootstrap_server(self):
 
         :return: true if the version of Kafka supports a new consumer with --bootstrap-server
         """
-        return self >= V_0_9_0_0
+        return True
 
     def supports_named_listeners(self):

Review Comment:
   ditto



##########
tests/kafkatest/services/performance/consumer_performance.py:
##########
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic, messages, version=DEV_BRANC
         assert version.consumer_supports_bootstrap_server() or (not new_consumer), \
             "new_consumer is only supported if version >= 0.9.0.0, version %s" % str(version)
 
-        assert version < V_2_0_0 or new_consumer, \

Review Comment:
   `new_consumer` is always `true`, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835567388


##########
tests/kafkatest/services/performance/consumer_performance.py:
##########
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic, messages, version=DEV_BRANC
         assert version.consumer_supports_bootstrap_server() or (not new_consumer), \
             "new_consumer is only supported if version >= 0.9.0.0, version %s" % str(version)
 
-        assert version < V_2_0_0 or new_consumer, \

Review Comment:
   https://issues.apache.org/jira/browse/KAFKA-17977
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835567141


##########
tests/kafkatest/services/performance/consumer_performance.py:
##########
@@ -77,9 +77,6 @@ def __init__(self, context, num_nodes, kafka, topic, messages, version=DEV_BRANC
         assert version.consumer_supports_bootstrap_server() or (not new_consumer), \
             "new_consumer is only supported if version >= 0.9.0.0, version %s" % str(version)
 
-        assert version < V_2_0_0 or new_consumer, \

Review Comment:
   yes and we can remove the `new_consumer` as follow-up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on PR #17673:
URL: https://github.com/apache/kafka/pull/17673#issuecomment-2466613195

   Hi @chia7712, I think this PR is ready.
   
   * For `client_compatibility_features_test.py` and `client_compatibility_produce_consume_test.py` failed cases, versions 2.1.1, 2.2.2, and 2.3.1 will be fixed in https://issues.apache.org/jira/browse/KAFKA-17888.
   * For `streams_upgrade_test.py` failed cases, they also failed in trunk branch. I have create https://issues.apache.org/jira/browse/KAFKA-17978 for followup. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835569444


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
             self.zk.start()
 
     @cluster(num_nodes=5)
-    # We are keeping 0.8.2 here so that we don't inadvertently break support for it. Since this is just a sanity check,
-    # the overhead should be manageable.
-    @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9), new_consumer=False)
-    @parametrize(version=str(LATEST_0_9))
-    @parametrize(version=str(LATEST_1_1), new_consumer=False)
-    @cluster(num_nodes=5)
+    @parametrize(version=str(LATEST_2_1), new_consumer=False)
     @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)

Review Comment:
   If we only apply this change on trunk branch, we also get same error. The reason is that `last` is `None`.
   
   ```
           last = None
           for line in node.account.ssh_capture(cmd):
               last = line
   
           # Parse and save the last line's information
           self.results[idx-1] = self.parse_results(last, node.version)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org