You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/06 22:03:59 UTC

[GitHub] [beam] Abacn commented on pull request #24773: remove duplicated null checks in Row.Equals

Abacn commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1374187076

   Suppose a={1, null}, b={2, null} so they have same size, but now a equals b because value and otherValue are both null.
   
   This is not get caught by unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org