You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Matthieu Chase Heimer (JIRA)" <ji...@apache.org> on 2008/05/14 07:36:05 UTC

[jira] Created: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

tiles-jsp.tld report escapes html when it shouldn't
---------------------------------------------------

                 Key: TILES-274
                 URL: https://issues.apache.org/struts/browse/TILES-274
             Project: Tiles
          Issue Type: Bug
          Components: tiles-jsp (jsp support)
    Affects Versions: 2.0.5
            Reporter: Matthieu Chase Heimer
            Priority: Minor


maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Matthieu Chase Heimer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthieu Chase Heimer updated TILES-274:
----------------------------------------

    Attachment: tiles-jsp-pom.diff

fix config for maven taglib html parsing

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Priority: Minor
>         Attachments: tiles-jsp-pom.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli resolved TILES-274.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.7

Patch submitted, in a modified form. Thanks Matthieu!

The next time, please, create patches against SVN repository.

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Assignee: Antonio Petrelli
>            Priority: Minor
>             Fix For: 2.0.7
>
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli reassigned TILES-274:
--------------------------------------

    Assignee: Antonio Petrelli

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Assignee: Antonio Petrelli
>            Priority: Minor
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli closed TILES-274.
----------------------------------


Closed due to the release of Tiles 2.0.7.

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Assignee: Antonio Petrelli
>            Priority: Minor
>             Fix For: 2.0.7
>
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43843#action_43843 ] 

Antonio Petrelli commented on TILES-274:
----------------------------------------

The TLD is designed to work with the Taglibdoc report, that is triggered by the "Maven taglib plugin":
http://maven-taglib.sourceforge.net/
The taglibdoc, in fact, is fine, while the tag reference page is horrible, but I really don't know how to turn off the tag reference, leaving the taglibdoc only.
Have you got any idea?

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Priority: Minor
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Matthieu Chase Heimer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43869#action_43869 ] 

Matthieu Chase Heimer commented on TILES-274:
---------------------------------------------

I used svn diff to create the patches. Are you saying I should always use trunk? What about with Struts? Would I have to submit patches for both the 2.0 branch and the 2.1 trunk? Please keep in mind that I'm looking to help fix the docs so most of my patches will be for the snippet sections.

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Assignee: Antonio Petrelli
>            Priority: Minor
>             Fix For: 2.0.7
>
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Matthieu Chase Heimer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43849#action_43849 ] 

Matthieu Chase Heimer commented on TILES-274:
---------------------------------------------

Does not look like there is a way to disable just the reference page but I think I've got it fixed. The maven-taglib plugin added a configuration option to deal with this option. See: http://sourceforge.net/tracker/index.php?func=detail&aid=1673837&group_id=93991&atid=606303. The only problem is the descriptions in the TLD have some invalid html and aren't always properly escaping characters.

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Priority: Minor
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Matthieu Chase Heimer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43851#action_43851 ] 

chase@osdev.org edited comment on TILES-274 at 5/14/08 10:33 PM:
-----------------------------------------------------------------------

Fix invalid html in descriptions and correctly escape characters

      was (Author: chase@osdev.org):
    File invalid html in descriptions and correctly escape characters
  
> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Priority: Minor
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Matthieu Chase Heimer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthieu Chase Heimer updated TILES-274:
----------------------------------------

    Attachment: tiles-jsp-tld.diff

File invalid html in descriptions and correctly escape characters

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Priority: Minor
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TILES-274) tiles-jsp.tld report escapes html when it shouldn't

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/TILES-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43873#action_43873 ] 

Antonio Petrelli commented on TILES-274:
----------------------------------------

Use preferably the trunk, but the TILES_2_0_X branch is ok for the moment, so the work of the committer is easier.
The merge process (from the trunk to the branch, or vice versa) will be made by a committer.
About Struts I assume they prefer the same process.

> tiles-jsp.tld report escapes html when it shouldn't
> ---------------------------------------------------
>
>                 Key: TILES-274
>                 URL: https://issues.apache.org/struts/browse/TILES-274
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-jsp (jsp support)
>    Affects Versions: 2.0.5
>            Reporter: Matthieu Chase Heimer
>            Assignee: Antonio Petrelli
>            Priority: Minor
>             Fix For: 2.0.7
>
>         Attachments: tiles-jsp-pom.diff, tiles-jsp-tld.diff
>
>
> maven-taglib-plugin is being used to generate a tld report that is displayed at http://tiles.apache.org/2.0/framework/tiles-jsp/tagreference.html. The  descriptions in the tld file contain html tags that are being escaped when generating the report resulting in the html source being displayed by the report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.