Re: [PR] [ISSUE #10496]Add sample plain_acl.yml to distribution/conf [rocketmq]

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #10497:
URL: https://github.com/apache/rocketmq/pull/10497#discussion_r3434177875


##########
distribution/conf/plain_acl.yml:
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+globalWhiteRemoteAddresses:
+  - 10.10.103.*

Review Comment:
   Please avoid shipping active global whitelist entries in a sample ACL file. If users copy this file into production, these private network ranges would bypass ACL checks. Consider commenting these entries out and explaining that they are examples only.



##########
distribution/conf/plain_acl.yml:
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+globalWhiteRemoteAddresses:
+  - 10.10.103.*
+  - 192.168.0.*
+
+accounts:
+  - accessKey: rocketmq2
+    secretKey: 12345678

Review Comment:
   This sample includes a default admin secret (`12345678`). Please add a clear warning to change these credentials before deployment, or make the account block commented-out example content to avoid accidental insecure production use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org