[jira] [Commented] (MASSEMBLY-614) useTransitiveFiltering implemented contrarily

["Antoine Tran (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MASSEMBLY-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310732#comment-17310732 ] 

Antoine Tran commented on MASSEMBLY-614:
----------------------------------------

Omg, I reproduced the issue! I thought I did something wrong and started searching on the internet for something that was supposed to work quite simply! Thanks for writing this report.

Now I need to write
{code:java}
<useTransitiveFiltering>false</useTransitiveFiltering>
{code}
to include dependencies, contrary to documentation. I think the proper correction would be, to avoid backward incompatibilities, to deprecate useTransitiveFiltering but not deleting it, in favor of another new property that implements it correctly, something like useTransitiveFilteringPattern or similar.

Using maven 3.5.3.

> useTransitiveFiltering implemented contrarily
> ---------------------------------------------
>
>                 Key: MASSEMBLY-614
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-614
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: dependencySet
>    Affects Versions: 2.3
>            Reporter: Joerg Schaible
>            Priority: Major
>
> useTransitiveFiltering is implemented wrongly, it filters when set to false and does not filter when set to true.
> One of the declared dependencies in the project is this:
> {code:xml}
> <dependency>
>   <groupId>com.sun.xml.ws</groupId>
>   <artifactId>jaxws-rt</artifactId>
>   <version>2.2.6</version>
> </dependency>
> {code}
> The assembly descriptor is:
> {code:xml}
> <dependencySet>
>   <unpack>false</unpack>
>   <useProjectArtifact>false</useProjectArtifact>
>   <useTransitiveDependencies>true</useTransitiveDependencies>
>   <useTransitiveFiltering>false</useTransitiveFiltering>
>   <includes>
>     <include>*:jaxws*</include>
>   </includes>
> </dependencySet>
> {code}
> The result contains only the jar for jaxws-rt, but not its dependencies. Setting useTransitiveFiltering to true, then all dependencies are included. It works quite contrary to the documentation and the implicit property name.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)