You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/06/06 01:00:25 UTC
Review Request 22281: Fixing broken increase_quota command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Bugs: AURORA-514
https://issues.apache.org/jira/browse/AURORA-514
Repository: aurora
Description
-------
Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
Diffs
-----
src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
Diff: https://reviews.apache.org/r/22281/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/commands:admin
Thanks,
Maxim Khutornenko
Re: Review Request 22281: Fixing broken increase_quota command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review44896
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On June 5, 2014, 7 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22281/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 7 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-514
> https://issues.apache.org/jira/browse/AURORA-514
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
> src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
>
> Diff: https://reviews.apache.org/r/22281/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/commands:admin
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22281: Fixing broken increase_quota command.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review45122
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 6, 2014, 11:01 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22281/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:01 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-514
> https://issues.apache.org/jira/browse/AURORA-514
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
> src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
>
> Diff: https://reviews.apache.org/r/22281/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/commands:admin
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22281: Fixing broken increase_quota command.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review45116
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On June 6, 2014, 11:01 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22281/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:01 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-514
> https://issues.apache.org/jira/browse/AURORA-514
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
> src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
>
> Diff: https://reviews.apache.org/r/22281/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/commands:admin
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22281: Fixing broken increase_quota command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/
-----------------------------------------------------------
(Updated June 6, 2014, 6:01 p.m.)
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Changes
-------
CR comments.
Bugs: AURORA-514
https://issues.apache.org/jira/browse/AURORA-514
Repository: aurora
Description
-------
Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
Diff: https://reviews.apache.org/r/22281/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/commands:admin
Thanks,
Maxim Khutornenko
Re: Review Request 22281: Fixing broken increase_quota command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 5, 2014, 11:32 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 213
> > <https://reviews.apache.org/r/22281/diff/1/?file=604420#file604420line213>
> >
> > You can just use "int" here and elsewhere and don't really need to think about overflow in python - see http://legacy.python.org/dev/peps/pep-0237/ for why.
Sure, done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review44868
-----------------------------------------------------------
On June 5, 2014, 11 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22281/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-514
> https://issues.apache.org/jira/browse/AURORA-514
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
> src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
>
> Diff: https://reviews.apache.org/r/22281/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/commands:admin
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22281: Fixing broken increase_quota command.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review44868
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/admin.py
<https://reviews.apache.org/r/22281/#comment79464>
You can just use "int" here and elsewhere and don't really need to think about overflow in python - see http://legacy.python.org/dev/peps/pep-0237/ for why.
- Kevin Sweeney
On June 5, 2014, 4 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22281/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 4 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-514
> https://issues.apache.org/jira/browse/AURORA-514
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116
> src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
>
> Diff: https://reviews.apache.org/r/22281/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/commands:admin
>
>
> Thanks,
>
> Maxim Khutornenko
>
>