You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/03/01 09:16:12 UTC
Review Request: Always extract zookeeper-*.tar.gz so that we can run 'make
check' (even if we are not building the native library).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4124/
-----------------------------------------------------------
Review request for mesos, Andy Konwinski and Charles Reiss.
Summary
-------
See summary.
Diffs
-----
third_party/Makefile.am cafdb00
Diff: https://reviews.apache.org/r/4124/diff
Testing
-------
./configure --without-included-zookeeper && make check
Thanks,
Benjamin
Re: Review Request: Always extract zookeeper-*.tar.gz so that we can run
'make check' (even if we are not building the native library).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-01 19:56:05, Charles Reiss wrote:
> > LGTM, but this should have a comment so future developers understand the obscure dependency (of src/tests/base_zookeeper_test.cpp, I assume).
Completely agree, thanks for the nudge!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4124/#review5516
-----------------------------------------------------------
On 2012-03-01 08:16:12, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4124/
> -----------------------------------------------------------
>
> (Updated 2012-03-01 08:16:12)
>
>
> Review request for mesos, Andy Konwinski and Charles Reiss.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/Makefile.am cafdb00
>
> Diff: https://reviews.apache.org/r/4124/diff
>
>
> Testing
> -------
>
> ./configure --without-included-zookeeper && make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Always extract zookeeper-*.tar.gz so that we can run
'make check' (even if we are not building the native library).
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4124/#review5516
-----------------------------------------------------------
Ship it!
LGTM, but this should have a comment so future developers understand the obscure dependency (of src/tests/base_zookeeper_test.cpp, I assume).
- Charles
On 2012-03-01 08:16:12, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4124/
> -----------------------------------------------------------
>
> (Updated 2012-03-01 08:16:12)
>
>
> Review request for mesos, Andy Konwinski and Charles Reiss.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/Makefile.am cafdb00
>
> Diff: https://reviews.apache.org/r/4124/diff
>
>
> Testing
> -------
>
> ./configure --without-included-zookeeper && make check
>
>
> Thanks,
>
> Benjamin
>
>