You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nikhil Bonte <ni...@freestoneinfotech.com> on 2019/10/09 06:47:27 UTC

Review Request 71600: ATLAS-3441 - Add JVM resource metrics for Atlas monitoring

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71600/
-----------------------------------------------------------

Review request for atlas and Sarath Subramanian.


Bugs: ATLAS-3441
    https://issues.apache.org/jira/browse/ATLAS-3441


Repository: atlas


Description
-------

This will include important JVM attributes to existing metric REST API for monitoring.

JSON structure:
{
  "data": {
    "general": {
    ...
    },
    "system": {
      "memory": {
        "heapCommitted": "687865856",
        "heapInit": "262144000",
        "heapMax": "954728448",
        "heapUsed": "398610416",
        "memory_pool_usages": {
          "PS Eden Space": {
            "committed": 217579520,
            "init": 66060288,
            "max": 302514176,
            "used": 171862912
          },
          "PS Old Gen": {
            "committed": 449314816,
            "init": 175112192,
            "max": 716177408,
            "used": 205808048
          },
          "PS Survivor Space": {
            "committed": 20971520,
            "init": 10485760,
            "max": 20971520,
            "used": 20939456
          }
        },
        "nonHeapCommitted": "172163072",
        "nonHeapInit": "2555904",
        "nonHeapMax": "-1",
        "nonHeapUsed": "168581552"
      },
      "os": {
        "os.spec": "Linux, amd64, 4.15.0-51-generic",
        "os.vcpus": "4"
      },
      "runtime": {
        "name": "OpenJDK 64-Bit Server VM",
        "version": "1.8.0_212"
      }
    }
  }
}


Diffs
-----

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 2a65b5558 
  repository/src/main/java/org/apache/atlas/util/AtlasMetricJVMUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/71600/diff/1/


Testing
-------

Verified using API - GET /api/atlas/admin/metrics


Thanks,

Nikhil Bonte


Re: Review Request 71600: ATLAS-3441 - Add JVM resource metrics for Atlas monitoring

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71600/#review218150
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 9, 2019, 6:47 a.m., Nikhil Bonte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71600/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2019, 6:47 a.m.)
> 
> 
> Review request for atlas and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3441
>     https://issues.apache.org/jira/browse/ATLAS-3441
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This will include important JVM attributes to existing metric REST API for monitoring.
> 
> JSON structure:
> {
>   "data": {
>     "general": {
>     ...
>     },
>     "system": {
>       "memory": {
>         "heapCommitted": "687865856",
>         "heapInit": "262144000",
>         "heapMax": "954728448",
>         "heapUsed": "398610416",
>         "memory_pool_usages": {
>           "PS Eden Space": {
>             "committed": 217579520,
>             "init": 66060288,
>             "max": 302514176,
>             "used": 171862912
>           },
>           "PS Old Gen": {
>             "committed": 449314816,
>             "init": 175112192,
>             "max": 716177408,
>             "used": 205808048
>           },
>           "PS Survivor Space": {
>             "committed": 20971520,
>             "init": 10485760,
>             "max": 20971520,
>             "used": 20939456
>           }
>         },
>         "nonHeapCommitted": "172163072",
>         "nonHeapInit": "2555904",
>         "nonHeapMax": "-1",
>         "nonHeapUsed": "168581552"
>       },
>       "os": {
>         "os.spec": "Linux, amd64, 4.15.0-51-generic",
>         "os.vcpus": "4"
>       },
>       "runtime": {
>         "name": "OpenJDK 64-Bit Server VM",
>         "version": "1.8.0_212"
>       }
>     }
>   }
> }
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 2a65b5558 
>   repository/src/main/java/org/apache/atlas/util/AtlasMetricJVMUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71600/diff/1/
> 
> 
> Testing
> -------
> 
> Verified using API - GET /api/atlas/admin/metrics
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>