You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/12/14 18:50:17 UTC
[PR] wip: Code cleanup [datafusion-ray]
andygrove opened a new pull request, #54:
URL: https://github.com/apache/datafusion-ray/pull/54
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Make query stage / shuffle code easier to understand [datafusion-ray]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #54:
URL: https://github.com/apache/datafusion-ray/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Make query stage / shuffle code easier to understand [datafusion-ray]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #54:
URL: https://github.com/apache/datafusion-ray/pull/54#discussion_r1885382237
##########
testdata/expected-plans/q1.txt:
##########
@@ -42,7 +42,7 @@ ShuffleWriterExec(stage_id=1, output_partitioning=Hash([Column { name: "l_return
CoalesceBatchesExec: target_batch_size=8192
ShuffleReaderExec(stage_id=0, input_partitioning=Hash([Column { name: "l_returnflag", index: 0 }, Column { name: "l_linestatus", index: 1 }], 2))
-Query Stage #2 (2 -> 1):
+Query Stage #2 (1 -> 1):
Review Comment:
`SortPreservingMergeExec` always produces a single partition, so it is correct that this query stage reports that it is going from 1 partition to 1 partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org