You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/23 15:13:50 UTC

[GitHub] [arrow] lidavidm opened a new pull request #12037: [C++][FlightRPC] Fix race between signal handler and shutdown

lidavidm opened a new pull request #12037:
URL: https://github.com/apache/arrow/pull/12037


   The Flight server spawns a background thread that reads from a pipe, then shuts down the server. (The pipe is written to by a signal handler). On normal shutdown, the server would close the pipe, then join the background thread, leading to a race: the background thread might read from the pipe again, getting a "bad fd" error. The fix is simple; just join the thread before closing the pipe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12037: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12037:
URL: https://github.com/apache/arrow/pull/12037#issuecomment-1000371397


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12037:
URL: https://github.com/apache/arrow/pull/12037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12037:
URL: https://github.com/apache/arrow/pull/12037#issuecomment-1000378940


   https://issues.apache.org/jira/browse/ARROW-15181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12037:
URL: https://github.com/apache/arrow/pull/12037#issuecomment-1002608371


   Benchmark runs are scheduled for baseline = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6 and contender = e46b0af6ec62c97dc8aa98d7d5b8468b37269198. e46b0af6ec62c97dc8aa98d7d5b8468b37269198 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8eadf0b61f4842baa3b7d98e8fb4de24...4cae42324113470e9df624213ff7a699/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/034ea6bfe92c4f4793a4bc6674d1acfd...4c6fb101c4df416496d2ad7fd86a6475/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1f0324c34af047ca893f404cb8ecfc4d...ae9688db17cb4c2ca76ee3073aadfef9/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12037:
URL: https://github.com/apache/arrow/pull/12037#issuecomment-1002608371


   Benchmark runs are scheduled for baseline = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6 and contender = e46b0af6ec62c97dc8aa98d7d5b8468b37269198. e46b0af6ec62c97dc8aa98d7d5b8468b37269198 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8eadf0b61f4842baa3b7d98e8fb4de24...4cae42324113470e9df624213ff7a699/)
   [Finished :arrow_down:0.45% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/034ea6bfe92c4f4793a4bc6674d1acfd...4c6fb101c4df416496d2ad7fd86a6475/)
   [Failed :arrow_down:0.58% :arrow_up:0.18%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1f0324c34af047ca893f404cb8ecfc4d...ae9688db17cb4c2ca76ee3073aadfef9/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12037:
URL: https://github.com/apache/arrow/pull/12037#issuecomment-1002608371


   Benchmark runs are scheduled for baseline = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6 and contender = e46b0af6ec62c97dc8aa98d7d5b8468b37269198. e46b0af6ec62c97dc8aa98d7d5b8468b37269198 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8eadf0b61f4842baa3b7d98e8fb4de24...4cae42324113470e9df624213ff7a699/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/034ea6bfe92c4f4793a4bc6674d1acfd...4c6fb101c4df416496d2ad7fd86a6475/)
   [Failed :arrow_down:0.58% :arrow_up:0.18%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1f0324c34af047ca893f404cb8ecfc4d...ae9688db17cb4c2ca76ee3073aadfef9/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12037:
URL: https://github.com/apache/arrow/pull/12037#issuecomment-1002608371


   Benchmark runs are scheduled for baseline = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6 and contender = e46b0af6ec62c97dc8aa98d7d5b8468b37269198. e46b0af6ec62c97dc8aa98d7d5b8468b37269198 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8eadf0b61f4842baa3b7d98e8fb4de24...4cae42324113470e9df624213ff7a699/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/034ea6bfe92c4f4793a4bc6674d1acfd...4c6fb101c4df416496d2ad7fd86a6475/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1f0324c34af047ca893f404cb8ecfc4d...ae9688db17cb4c2ca76ee3073aadfef9/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org