You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/21 11:18:51 UTC
[GitHub] [pulsar-client-go] aahmed-se commented on a change in pull request #292: Used pooled buffering for compression and batch serialization
aahmed-se commented on a change in pull request #292:
URL: https://github.com/apache/pulsar-client-go/pull/292#discussion_r443209190
##########
File path: pulsar/consumer_partition.go
##########
@@ -859,7 +859,7 @@ func (pc *partitionConsumer) Decompress(msgMeta *pb.MessageMetadata, payload int
pc.compressionProviders[msgMeta.GetCompression()] = provider
}
- uncompressed, err := provider.Decompress(payload.ReadableSlice(), int(msgMeta.GetUncompressedSize()))
+ uncompressed, err := provider.Decompress(nil, payload.ReadableSlice(), int(msgMeta.GetUncompressedSize()))
Review comment:
have a method definition that does not require nil as a parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org