You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jhuynh1 (GitHub)" <gi...@apache.org> on 2019/12/24 22:06:51 UTC

[GitHub] [geode] jhuynh1 opened pull request #4530: [WIP] code cleanup

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4530 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] lgtm-com[bot] commented on issue #4530: [WIP] code cleanup

Posted by lg...@gitbox.apache.org.
This pull request **introduces 1 alert** and **fixes 1** when merging 80a736ab0c3b37eb290602223088ae10eca4636e into 8944e897eeef3e9fcb79d97959c431595f2d9a35 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-fb659a9d28f139aa06067cdd9a784baf5689d295)

**new alerts:**

* 1 for Dereferenced variable may be null

**fixed alerts:**

* 1 for Equals method does not inspect argument type

[ Full content available at: https://github.com/apache/geode/pull/4530 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org