You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/17 16:14:33 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new issue #5291: Log Spam from Riak services in Traffic Ops
ocket8888 opened a new issue #5291:
URL: https://github.com/apache/trafficcontrol/issues/5291
## I'm submitting a ...
- bug report
## Traffic Control components affected ...
- Traffic Ops
## Current behavior:
Traffic Ops will sometimes emit the error:
```
ERROR: riak_services.go:343: 2020-11-17T14:10:49.716927165Z: getting riak servers: querying riak servers: sql: transaction has already been committed or rolled back
```
when encountering an error in Riak-related endpoint logic. It's probably calling `HandleErr` without returning.
## Expected behavior:
When a fatal error occurs, handling should end and no further attempts should be made to roll back the linked transaction.
## Minimal reproduction of the problem with instructions:
I think you can actually just see it in the default CDN-in-a-Box setup logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed issue #5291: Log Spam from Riak services in Traffic Ops
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #5291:
URL: https://github.com/apache/trafficcontrol/issues/5291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5291: Log Spam from Riak services in Traffic Ops
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5291:
URL: https://github.com/apache/trafficcontrol/issues/5291#issuecomment-983924507
Riak KV as a backend for Traffic Vault is deprecated, so we won't be fixing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c edited a comment on issue #5291: Log Spam from Riak services in Traffic Ops
Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on issue #5291:
URL: https://github.com/apache/trafficcontrol/issues/5291#issuecomment-729038303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c edited a comment on issue #5291: Log Spam from Riak services in Traffic Ops
Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on issue #5291:
URL: https://github.com/apache/trafficcontrol/issues/5291#issuecomment-729038303
>It's probably calling HandleErr without returning.
If it is, you should see this in the logs:
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/api.go#L134
> called after a write already occurred! Not double-writing!
FWIW I've seen that `transaction has already been committed or rolled back` in the past, after strange query errors. Certain bad queries -- which didn't commit or rollback -- seem to cause all future queries on the same transaction to return that. I don't fully understand why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #5291: Log Spam from Riak services in Traffic Ops
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5291:
URL: https://github.com/apache/trafficcontrol/issues/5291#issuecomment-729038303
>It's probably calling HandleErr without returning.
If it is, you should see this in the logs:
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/api.go#L134
> called after a write already occurred! Not double-writing!
FWIW I've seen that `transaction has already been committed or rolled back` in the past, after strange query errors. Certain bad queries -- which didn't commit or rollback -- seem to cause all future queries on the same transaction. I don't fully understand why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org