You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "e-mhui (via GitHub)" <gi...@apache.org> on 2023/03/17 10:57:12 UTC

[GitHub] [inlong] e-mhui opened a new pull request, #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

e-mhui opened a new pull request, #7638:
URL: https://github.com/apache/inlong/pull/7638

   ### Prepare a Pull Request
   
   MongoDB CDC supports metrics with enable incremental snapshots
   
   - Fixes #7635 
   
   ### Motivation
   
   MongoDB CDC supports metrics with enable incremental snapshots.
   
   ### Modifications
   
   To be added later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] e-mhui commented on pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on PR #7638:
URL: https://github.com/apache/inlong/pull/7638#issuecomment-1474556569

   > I suggest mongo module don't use same package path with cdc-base module
   
   Thanks, pls review this pr https://github.com/apache/inlong/pull/7640 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on a diff in pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7638:
URL: https://github.com/apache/inlong/pull/7638#discussion_r1149134922


##########
inlong-sort/sort-connectors/mongodb-cdc/src/main/java/org/apache/inlong/sort/cdc/mongodb/source/utils/BsonUtils.java:
##########
@@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.cdc.mongodb.source.utils;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+import org.bson.BsonArray;
+import org.bson.BsonBinary;
+import org.bson.BsonDbPointer;
+import org.bson.BsonDocument;
+import org.bson.BsonJavaScriptWithScope;
+import org.bson.BsonObjectId;
+import org.bson.BsonRegularExpression;
+import org.bson.BsonString;
+import org.bson.BsonType;
+import org.bson.BsonUndefined;
+import org.bson.BsonValue;
+import org.bson.types.Decimal128;
+
+/** Utility class to deal {@link BsonValue}s.
+ * Copy from com.ververica:flink-connector-mongodb-cdc:2.3.0.
+ */
+public class BsonUtils {

Review Comment:
   can it be reused from flinkcdc ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] kuansix commented on pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "kuansix (via GitHub)" <gi...@apache.org>.
kuansix commented on PR #7638:
URL: https://github.com/apache/inlong/pull/7638#issuecomment-1474068764

   来信已收到，谢谢！


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7638:
URL: https://github.com/apache/inlong/pull/7638


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7638:
URL: https://github.com/apache/inlong/pull/7638#issuecomment-1474127479

   I suggest mongo module don't use same package path with cdc-base module


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] e-mhui commented on pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on PR #7638:
URL: https://github.com/apache/inlong/pull/7638#issuecomment-1474068119

   @gong @yunqingmoswu @EMsnap @kuansix Hi, pls review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] e-mhui commented on a diff in pull request #7638: [INLONG-7635][Sort] MongoDB CDC supports metrics with enable incremental snapshots

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #7638:
URL: https://github.com/apache/inlong/pull/7638#discussion_r1149215257


##########
inlong-sort/sort-connectors/mongodb-cdc/src/main/java/org/apache/inlong/sort/cdc/mongodb/source/utils/BsonUtils.java:
##########
@@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.cdc.mongodb.source.utils;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+import org.bson.BsonArray;
+import org.bson.BsonBinary;
+import org.bson.BsonDbPointer;
+import org.bson.BsonDocument;
+import org.bson.BsonJavaScriptWithScope;
+import org.bson.BsonObjectId;
+import org.bson.BsonRegularExpression;
+import org.bson.BsonString;
+import org.bson.BsonType;
+import org.bson.BsonUndefined;
+import org.bson.BsonValue;
+import org.bson.types.Decimal128;
+
+/** Utility class to deal {@link BsonValue}s.
+ * Copy from com.ververica:flink-connector-mongodb-cdc:2.3.0.
+ */
+public class BsonUtils {

Review Comment:
   yes, it had been removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org