You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/22 06:44:38 UTC

[GitHub] [incubator-dolphinscheduler] kezhenxu94 commented on a change in pull request #4529: [Improvement][Docker] Reduce docker image size and improve log out

kezhenxu94 commented on a change in pull request #4529:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4529#discussion_r562409911



##########
File path: .gitignore
##########
@@ -4,43 +4,41 @@
 .zip
 .gz
 .DS_Store
+.target
 .idea/
-dist/
-all-dependencies.txt
-self-modules.txt
-third-party-dependencies.txt

Review comment:
       I don't know why you remove these, these are aim to avoid mistakenly checking into codebase when running local check (they are generated when running local check)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org