You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/02 16:17:40 UTC
[GitHub] [dubbo-go-samples] LaurenceLiZhixin opened a new pull request #155: fix: fix dynamic naming mapping of app level service disc
LaurenceLiZhixin opened a new pull request #155:
URL: https://github.com/apache/dubbo-go-samples/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on pull request #155: fix: fix dynamic naming mapping of app level service disc
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #155:
URL: https://github.com/apache/dubbo-go-samples/pull/155#issuecomment-878787374
merge it forcefully as admin right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #155: fix: fix dynamic naming mapping of app level service disc
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #155:
URL: https://github.com/apache/dubbo-go-samples/pull/155#discussion_r663374741
##########
File path: registry/servicediscovery/zookeeper/go-server/cmd/server.go
##########
@@ -37,7 +38,7 @@ import (
_ "dubbo.apache.org/dubbo-go/v3/common/proxy/proxy_factory"
"dubbo.apache.org/dubbo-go/v3/config"
_ "dubbo.apache.org/dubbo-go/v3/filter/filter_impl"
- _ "dubbo.apache.org/dubbo-go/v3/metadata/mapping/memory"
+ _ "dubbo.apache.org/dubbo-go/v3/metadata/mapping/dynamic"
Review comment:
move all dubbo.apache.org/dubbo-go/v3 into the 2rd import block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #155: fix: fix dynamic naming mapping of app level service disc
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #155:
URL: https://github.com/apache/dubbo-go-samples/pull/155#discussion_r663374684
##########
File path: registry/servicediscovery/zookeeper/go-server/cmd/server.go
##########
@@ -26,6 +26,7 @@ import (
)
import (
+ _ "dubbo.apache.org/dubbo-go/v3/config_center/zookeeper"
hessian "github.com/apache/dubbo-go-hessian2"
"github.com/apache/dubbo-go-samples/registry/servicediscovery/zookeeper/go-server/pkg"
Review comment:
put it into the 3rd import block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #155: fix: fix dynamic naming mapping of app level service disc
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #155:
URL: https://github.com/apache/dubbo-go-samples/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org