You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/09/06 02:22:42 UTC

[GitHub] [incubator-shardingsphere] pitymonkey commented on a change in pull request #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

pitymonkey commented on a change in pull request #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
URL: https://github.com/apache/incubator-shardingsphere/pull/2967#discussion_r321553959
 
 

 ##########
 File path: sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/test/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/util/DataSourceUtilTest.java
 ##########
 @@ -119,4 +120,12 @@ public void assertDataSourceForLongValue() throws ReflectiveOperationException {
         assertThat(actual.getTimeBetweenEvictionRunsMillis(), is(16L));
         assertThat(actual.getMinEvictableIdleTimeMillis(), is(4000L));
     }
+
+    @Test
+    public void assertDataSourceForCollectionValue() throws ReflectiveOperationException {
+        Map<String, Object> dataSourceProperties = new HashMap<>(2, 1);
+        dataSourceProperties.put("connectionInitSqls", "[set names utf8mb4]");
 
 Review comment:
   I have make it support "," only

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services