You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/30 12:23:08 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13390: ARROW-16424: [C++] Update uri_path parsing in FromProto

pitrou commented on code in PR #13390:
URL: https://github.com/apache/arrow/pull/13390#discussion_r910961052


##########
cpp/src/arrow/util/uri.h:
##########
@@ -68,6 +68,9 @@ class ARROW_EXPORT Uri {
   /// The URI path component.
   std::string path() const;
 
+  /// The Extension component for file
+  std::string extension() const;

Review Comment:
   There is no concept of extension in URIs (the path may not represent a filename at all). Can't you just make it a private utility in substrait?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org