You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/11/16 17:22:19 UTC
Review Request 53814: GEODE-2100 Add new version of query client
server messages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53814/
-----------------------------------------------------------
Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith.
Repository: geode
Description
-------
Added new versions of messages, preventing CumulativeNonDistinctResults from being sent back to a pre Geode client.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 08c2ecf
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java 579a3e1
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java a6dc022
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java 51b2a24
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryGeode10.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryWithParametersGeode10.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java 838bb29
Diff: https://reviews.apache.org/r/53814/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 53814: GEODE-2100 Add new version of query client
server messages
Posted by Jason Huynh <jh...@pivotal.io>.
> On Nov. 16, 2016, 6:06 p.m., Dan Smith wrote:
> > What is the JUnit4DistributedTestCase change for?
If a previous test failed with suspect strings in tearDownDistributedTestCase, the postTearDown would not get called for the unit test. This then caused the rest of the tests to fail because any clean up for that specific test was not being done.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53814/#review156087
-----------------------------------------------------------
On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53814/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 5:22 p.m.)
>
>
> Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added new versions of messages, preventing CumulativeNonDistinctResults from being sent back to a pre Geode client.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 08c2ecf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java 579a3e1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java a6dc022
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java 51b2a24
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryGeode10.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryWithParametersGeode10.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java 838bb29
>
> Diff: https://reviews.apache.org/r/53814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 53814: GEODE-2100 Add new version of query client
server messages
Posted by Dan Smith <ds...@pivotal.io>.
> On Nov. 16, 2016, 6:06 p.m., Dan Smith wrote:
> > What is the JUnit4DistributedTestCase change for?
>
> Jason Huynh wrote:
> If a previous test failed with suspect strings in tearDownDistributedTestCase, the postTearDown would not get called for the unit test. This then caused the rest of the tests to fail because any clean up for that specific test was not being done.
Makes sense. Thanks!
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53814/#review156087
-----------------------------------------------------------
On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53814/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 5:22 p.m.)
>
>
> Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added new versions of messages, preventing CumulativeNonDistinctResults from being sent back to a pre Geode client.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 08c2ecf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java 579a3e1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java a6dc022
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java 51b2a24
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryGeode10.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryWithParametersGeode10.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java 838bb29
>
> Diff: https://reviews.apache.org/r/53814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 53814: GEODE-2100 Add new version of query client
server messages
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53814/#review156087
-----------------------------------------------------------
Ship it!
What is the JUnit4DistributedTestCase change for?
- Dan Smith
On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53814/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 5:22 p.m.)
>
>
> Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added new versions of messages, preventing CumulativeNonDistinctResults from being sent back to a pre Geode client.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 08c2ecf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java 579a3e1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java a6dc022
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java 51b2a24
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryGeode10.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryWithParametersGeode10.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java 838bb29
>
> Diff: https://reviews.apache.org/r/53814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 53814: GEODE-2100 Add new version of query client
server messages
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53814/#review156104
-----------------------------------------------------------
Ship it!
Ship It!
- Barry Oglesby
On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53814/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 5:22 p.m.)
>
>
> Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added new versions of messages, preventing CumulativeNonDistinctResults from being sent back to a pre Geode client.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java 08c2ecf
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java 579a3e1
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java a6dc022
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java 51b2a24
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryGeode10.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryWithParametersGeode10.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java 838bb29
>
> Diff: https://reviews.apache.org/r/53814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>