You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2016/11/16 23:53:02 UTC

Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53828/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1300
    https://issues.apache.org/jira/browse/ATLAS-1300


Repository: atlas


Description
-------

The current v1 Lineage API (LineageResource) needs to route to the new v2 Lineage API (LineageREST).
1. Inputs Graph
2. Outputs Graph


Diffs
-----

  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 811c486 
  webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53828/diff/


Testing
-------

Tested using POSTman Rest client


Thanks,

Sarath Subramanian

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53828/#review157141
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 28, 2016, 8:54 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53828/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 8:54 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1300
>     https://issues.apache.org/jira/browse/ATLAS-1300
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The current v1 Lineage API (LineageResource) needs to route to the new v2 Lineage API (LineageREST).
> 1. Inputs Graph
> 2. Outputs Graph
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 983bbb8 
>   webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53828/diff/
> 
> 
> Testing
> -------
> 
> Tested using POSTman Rest client
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53828/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 12:54 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Changes
-------

addressed review comments


Bugs: ATLAS-1300
    https://issues.apache.org/jira/browse/ATLAS-1300


Repository: atlas


Description
-------

The current v1 Lineage API (LineageResource) needs to route to the new v2 Lineage API (LineageREST).
1. Inputs Graph
2. Outputs Graph


Diffs (updated)
-----

  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 983bbb8 
  webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53828/diff/


Testing
-------

Tested using POSTman Rest client


Thanks,

Sarath Subramanian

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53828/#review157090
-----------------------------------------------------------


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java (line 57)
<https://reviews.apache.org/r/53828/#comment227510>

    consider marking 'typeRegistry' as final.



webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java (line 120)
<https://reviews.apache.org/r/53828/#comment227515>

    Consider the following alternate - to take care cases where DataSet is not a direct superType:
    
    AtlasType type = registry.getType(typeName);
    
    if (type instanceof AtlasEntityType) {
      AtlasEntityType entityType = (AtlasEntityType)type;
    
      ret = entityType.getAllSuperTypes().contains(AtlasBaseTypeDef.ATLAS_TYPE_DATASET);
    }


- Madhan Neethiraj


On Nov. 28, 2016, 6:31 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53828/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:31 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1300
>     https://issues.apache.org/jira/browse/ATLAS-1300
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The current v1 Lineage API (LineageResource) needs to route to the new v2 Lineage API (LineageREST).
> 1. Inputs Graph
> 2. Outputs Graph
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 811c486 
>   webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53828/diff/
> 
> 
> Testing
> -------
> 
> Tested using POSTman Rest client
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53828/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 10:31 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Changes
-------

rebased the patch


Bugs: ATLAS-1300
    https://issues.apache.org/jira/browse/ATLAS-1300


Repository: atlas


Description
-------

The current v1 Lineage API (LineageResource) needs to route to the new v2 Lineage API (LineageREST).
1. Inputs Graph
2. Outputs Graph


Diffs (updated)
-----

  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 811c486 
  webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53828/diff/


Testing
-------

Tested using POSTman Rest client


Thanks,

Sarath Subramanian

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53828/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 10:20 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1300
    https://issues.apache.org/jira/browse/ATLAS-1300


Repository: atlas


Description
-------

The current v1 Lineage API (LineageResource) needs to route to the new v2 Lineage API (LineageREST).
1. Inputs Graph
2. Outputs Graph


Diffs (updated)
-----

  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 811c486 
  webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/53828/diff/


Testing
-------

Tested using POSTman Rest client


Thanks,

Sarath Subramanian