[GitHub] [airflow] lwyszomi commented on a diff in pull request #24046: Added impersonation_chain for dataflow operators

[GitBox <gi...@apache.org>]

lwyszomi commented on code in PR #24046:
URL: https://github.com/apache/airflow/pull/24046#discussion_r886345215


##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -972,16 +972,31 @@ def start_sql_job(
         :param on_new_job_callback: Callback called when the job is known.
         :return: the new job object
         """
+        gcp_options = [
+            f"--project={project_id}",
+            "--format=value(job.id)",
+            f"--job-name={job_name}",
+            f"--region={location}",
+        ]
+
+        if self.impersonation_chain:
+            if isinstance(self.impersonation_chain, str):
+                impersonation_account = self.impersonation_chain
+            elif len(self.impersonation_chain) == 1:
+                impersonation_account = self.impersonation_chain[1]

Review Comment:
   yeap, my mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org