You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/08/20 15:58:25 UTC

[GitHub] spark pull request #22155: [SPARK-25144][SQL][TEST] Free aggregate map when ...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/22155

    [SPARK-25144][SQL][TEST] Free aggregate map when task ends

    ## What changes were proposed in this pull request?
    
    [SPARK-25144](https://issues.apache.org/jira/browse/SPARK-25144) reports memory leaks on Apache Spark 2.0.2 ~ 2.3.2-RC5. The bug is already fixed via #21738 as a part of SPARK-21743. This PR only adds a test case to prevent any future regression.
    
    ```scala
    scala> case class Foo(bar: Option[String])
    scala> val ds = List(Foo(Some("bar"))).toDS
    scala> val result = ds.flatMap(_.bar).distinct
    scala> result.rdd.isEmpty
    18/08/19 23:01:54 WARN Executor: Managed memory leak detected; size = 8650752 bytes, TID = 125
    res0: Boolean = false
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins with a new added test case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-25144-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22155
    
----
commit 27497f5c92182df12e1f5750adf1384a4b7084d0
Author: Dongjoon Hyun <do...@...>
Date:   2018-08-20T15:55:12Z

    [SPARK-25144][SQL][TEST] Free aggregate map when task ends

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    Thank you!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    **[Test build #94962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94962/testReport)** for PR 22155 at commit [`27497f5`](https://github.com/apache/spark/commit/27497f5c92182df12e1f5750adf1384a4b7084d0).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `case class Foo(bar: Option[String])`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    **[Test build #94962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94962/testReport)** for PR 22155 at commit [`27497f5`](https://github.com/apache/spark/commit/27497f5c92182df12e1f5750adf1384a4b7084d0).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    cc @HyukjinKwon 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22155: [SPARK-25144][SQL][TEST] Free aggregate map when task en...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22155
  
    Thank you for review and approval, @HyukjinKwon .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org