You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2015/10/22 03:46:29 UTC
incubator-kylin git commit: KYLIN-1068 sanityCheck for TopN
Repository: incubator-kylin
Updated Branches:
refs/heads/KYLIN-1068 5b23d5612 -> 864f9b464
KYLIN-1068 sanityCheck for TopN
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/864f9b46
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/864f9b46
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/864f9b46
Branch: refs/heads/KYLIN-1068
Commit: 864f9b4641c0915752c183a045a4ee76df44a948
Parents: 5b23d56
Author: shaofengshi <sh...@apache.org>
Authored: Thu Oct 22 09:46:07 2015 +0800
Committer: shaofengshi <sh...@apache.org>
Committed: Thu Oct 22 09:46:07 2015 +0800
----------------------------------------------------------------------
.../main/java/org/apache/kylin/common/topn/TopNCounter.java | 2 ++
.../org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java | 8 ++++----
2 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/864f9b46/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
----------------------------------------------------------------------
diff --git a/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java b/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
index 0196be7..db5e0c8 100644
--- a/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
+++ b/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
@@ -210,10 +210,12 @@ public class TopNCounter<T> implements ITopK<T>, Iterable<Counter<T>> {
public TopNCounter<T> merge(TopNCounter<T> another) {
double m1 = 0.0, m2 = 0.0;
if (this.size() >= this.capacity) {
+ assert (this.capacity > 0);
m1 = this.counterList.tail().getValue().count;
}
if (another.size() >= another.capacity) {
+ assert (another.capacity > 0);
m2 = another.counterList.tail().getValue().count;
}
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/864f9b46/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
index 287b465..62a6a5d 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
@@ -479,7 +479,7 @@ public class InMemCubeBuilder extends AbstractInMemCubeBuilder {
builder.write(newRecord);
}
- // disable sanity check for performance
+ // FIXME: sanity check is only for dev/testing (especially for TopN), need disable when make release
sanityCheck(parentId, cuboidId, scanner.getTotalSumForSanityCheck());
} finally {
scanner.close();
@@ -516,9 +516,9 @@ public class InMemCubeBuilder extends AbstractInMemCubeBuilder {
return;
}
if (Arrays.equals(totalSumForSanityCheck, totalSum) == false) {
- logger.error("sanityCheck failed when calculate " + cuboidId + " from parent " + parentId);
- logger.info("Expected: " + Arrays.toString(totalSumForSanityCheck));
- logger.info("Actually: " + Arrays.toString(totalSum));
+ System.err.println("sanityCheck failed when calculate " + cuboidId + " from parent " + parentId);
+ System.err.println("Expected: " + Arrays.toString(totalSumForSanityCheck));
+ System.err.println("Actually: " + Arrays.toString(totalSum));
throw new IllegalStateException();
}
}