You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/07/07 16:22:52 UTC
svn commit: r1862701 -
/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/TextPosition.java
Author: tilman
Date: Sun Jul 7 16:22:52 2019
New Revision: 1862701
URL: http://svn.apache.org/viewvc?rev=1862701&view=rev
Log:
PDFBOX-4071: SonarQube fix: remove conditions that are always true
Modified:
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/TextPosition.java
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/TextPosition.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/TextPosition.java?rev=1862701&r1=1862700&r2=1862701&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/TextPosition.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/util/TextPosition.java Sun Jul 7 16:22:52 2019
@@ -731,14 +731,14 @@ public class TextPosition
}
//diacritic completely covers this character and therefore we assume that
//this is the character the diacritic belongs to
- else if(diacXStart < currCharXStart && diacXEnd > currCharXEnd)
+ else if (diacXStart < currCharXStart)
{
insertDiacritic(i, diacritic, normalize);
wasAdded = true;
}
//Otherwise, The diacritic modifies this character because its completely
//contained by the character width
- else if(diacXStart >= currCharXStart && diacXEnd <= currCharXEnd)
+ else if (diacXEnd <= currCharXEnd)
{
insertDiacritic(i, diacritic, normalize);
wasAdded = true;
@@ -746,7 +746,7 @@ public class TextPosition
/*
* Last character in the TextPosition so we add diacritic to the end
*/
- else if(diacXStart >= currCharXStart && diacXEnd > currCharXEnd && i == (strLen - 1))
+ else if (i == strLen - 1)
{
insertDiacritic(i, diacritic, normalize);
wasAdded = true;