[GitHub] eolivelli commented on a change in pull request #1637: BookieWatcherImpl doesn't initCause when throwing MetaStoreException

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1637: BookieWatcherImpl doesn't initCause when throwing MetaStoreException
URL: https://github.com/apache/bookkeeper/pull/1637#discussion_r214003562
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java
 ##########
 @@ -62,7 +62,9 @@
             log.error("Interrupted reading bookie list : ", cause);
             return new BKInterruptedException();
         } else {
-            return new MetaStoreException();
+            MetaStoreException mse = new MetaStoreException();
 
 Review comment:
   We should add a constructor which takes directly the cause

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services