You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/06/08 18:12:56 UTC

svn commit: r1833198 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation: PDAnnotationText.java handlers/PDTextAppearanceHandler.java

Author: tilman
Date: Fri Jun  8 18:12:56 2018
New Revision: 1833198

URL: http://svn.apache.org/viewvc?rev=1833198&view=rev
Log:
PDFBOX-3353: add constant for /Circle

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationText.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationText.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationText.java?rev=1833198&r1=1833197&r2=1833198&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationText.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationText.java Fri Jun  8 18:12:56 2018
@@ -70,6 +70,11 @@ public class PDAnnotationText extends PD
     public static final String NAME_INSERT = "Insert";
 
     /**
+     * Constant for the name of a circle annotation.
+     */
+    public static final String NAME_CIRCLE = "Circle";
+
+    /**
      * The type of annotation.
      */
     public static final String SUB_TYPE = "Text";

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java?rev=1833198&r1=1833197&r2=1833198&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java Fri Jun  8 18:12:56 2018
@@ -53,7 +53,7 @@ public class PDTextAppearanceHandler ext
         PDAnnotationText annotation = (PDAnnotationText) getAnnotation();
         if (!PDAnnotationText.NAME_NOTE.equals(annotation.getName()) &&
                 !PDAnnotationText.NAME_INSERT.equals(annotation.getName()) &&
-                !"Circle".equals(annotation.getName()))
+                !PDAnnotationText.NAME_CIRCLE.equals(annotation.getName()))
         {
             //TODO Comment, Key, Help, NewParagraph, Paragraph
             return;
@@ -84,7 +84,7 @@ public class PDTextAppearanceHandler ext
                 case PDAnnotationText.NAME_NOTE:
                     drawNote(contentStream, bbox);
                     break;
-                case "Circle": //TODO constant
+                case PDAnnotationText.NAME_CIRCLE:
                     drawCircles(contentStream, bbox);
                     break;
                 case PDAnnotationText.NAME_INSERT: