You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/19 20:43:50 UTC

[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #573: [YUNIKORN-1802] Add wrapper for node events

pbacsko commented on code in PR #573:
URL: https://github.com/apache/yunikorn-core/pull/573#discussion_r1234464610


##########
pkg/scheduler/objects/node.go:
##########
@@ -27,6 +27,7 @@ import (
 	"go.uber.org/zap"

Review Comment:
   General comment: we don't have event change details for placeholder replacement and reservation/unreservation. I don't know if we need those or not, I assume the replace would be useful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org