You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by xu...@apache.org on 2026/10/14 07:48:52 UTC

(amoro) branch master updated: [AMORO-4439][AMS] Fix wrong placeholder usage in Preconditions messages (#4440)

This is an automated email from the ASF dual-hosted git repository.

xxubai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new a38c4ba3b [AMORO-4439][AMS] Fix wrong placeholder usage in Preconditions messages (#4440)
a38c4ba3b is described below

commit a38c4ba3b50e46cc1486fdf767fbac8fa854734e
Author: Sivakumar Mahalingam <36...@users.noreply.github.com>
AuthorDate: Wed Oct 14 11:48:48 2026 +0400

    [AMORO-4439][AMS] Fix wrong placeholder usage in Preconditions messages (#4440)
    
    fix wrong placeholder usage in Preconditions messages
---
 .../org/apache/amoro/server/manager/FlinkOptimizerContainer.java  | 8 ++++----
 .../org/apache/amoro/server/manager/SparkOptimizerContainer.java  | 4 ++--
 .../java/org/apache/amoro/server/table/RuntimeHandlerChain.java   | 2 +-
 .../java/org/apache/amoro/formats/hudi/HudiHadoopCatalog.java     | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/amoro-ams/src/main/java/org/apache/amoro/server/manager/FlinkOptimizerContainer.java b/amoro-ams/src/main/java/org/apache/amoro/server/manager/FlinkOptimizerContainer.java
index b93050f03..19a46d48c 100644
--- a/amoro-ams/src/main/java/org/apache/amoro/server/manager/FlinkOptimizerContainer.java
+++ b/amoro-ams/src/main/java/org/apache/amoro/server/manager/FlinkOptimizerContainer.java
@@ -390,7 +390,7 @@ public class FlinkOptimizerContainer extends AbstractOptimizerContainer {
     if (target.runByFlinkRestClient()) {
       Preconditions.checkArgument(
           resource.getProperties().containsKey(SESSION_CLUSTER_JOB_ID),
-          "Cannot find {} from optimizer start up stats",
+          "Cannot find %s from optimizer start up stats",
           SESSION_CLUSTER_JOB_ID);
       String jobId = resource.getProperties().get(SESSION_CLUSTER_JOB_ID);
       Configuration configuration =
@@ -443,14 +443,14 @@ public class FlinkOptimizerContainer extends AbstractOptimizerContainer {
   private String buildReleaseYarnCommand(Resource resource) {
     Preconditions.checkArgument(
         resource.getProperties().containsKey(YARN_APPLICATION_ID_PROPERTY),
-        "Cannot find {} from optimizer start up stats",
+        "Cannot find %s from optimizer start up stats",
         YARN_APPLICATION_ID_PROPERTY);
     String applicationId = resource.getProperties().get(YARN_APPLICATION_ID_PROPERTY);
     String options = "-Dyarn.application.id=" + applicationId;
 
     Preconditions.checkArgument(
         resource.getProperties().containsKey(Resource.PROPERTY_JOB_ID),
-        "Cannot find {} from optimizer properties",
+        "Cannot find %s from optimizer properties",
         Resource.PROPERTY_JOB_ID);
     String jobId = resource.getProperties().get(Resource.PROPERTY_JOB_ID);
     return String.format(
@@ -460,7 +460,7 @@ public class FlinkOptimizerContainer extends AbstractOptimizerContainer {
   private String buildReleaseKubernetesCommand(Resource resource) {
     Preconditions.checkArgument(
         resource.getProperties().containsKey(KUBERNETES_CLUSTER_ID_PROPERTY),
-        "Cannot find {} from optimizer start up stats.",
+        "Cannot find %s from optimizer start up stats.",
         KUBERNETES_CLUSTER_ID_PROPERTY);
     String clusterId = resource.getProperties().get(KUBERNETES_CLUSTER_ID_PROPERTY);
 
diff --git a/amoro-ams/src/main/java/org/apache/amoro/server/manager/SparkOptimizerContainer.java b/amoro-ams/src/main/java/org/apache/amoro/server/manager/SparkOptimizerContainer.java
index 775ecfdbd..910df4837 100644
--- a/amoro-ams/src/main/java/org/apache/amoro/server/manager/SparkOptimizerContainer.java
+++ b/amoro-ams/src/main/java/org/apache/amoro/server/manager/SparkOptimizerContainer.java
@@ -277,7 +277,7 @@ public class SparkOptimizerContainer extends AbstractOptimizerContainer {
   private String buildReleaseYarnCommand(Resource resource) {
     Preconditions.checkArgument(
         resource.getProperties().containsKey(YARN_APPLICATION_ID_PROPERTY),
-        "Cannot find {} from optimizer start up stats",
+        "Cannot find %s from optimizer start up stats",
         YARN_APPLICATION_ID_PROPERTY);
     String applicationId = resource.getProperties().get(YARN_APPLICATION_ID_PROPERTY);
     return String.format(
@@ -288,7 +288,7 @@ public class SparkOptimizerContainer extends AbstractOptimizerContainer {
     Map<String, String> sparkConfig = loadSparkConfig();
     Preconditions.checkArgument(
         resource.getProperties().containsKey(KUBERNETES_SUBMISSION_ID_PROPERTY),
-        "Cannot find {} from optimizer start up stats.",
+        "Cannot find %s from optimizer start up stats.",
         KUBERNETES_SUBMISSION_ID_PROPERTY);
     SparkOptimizerContainer.SparkConf resourceSparkConf =
         SparkOptimizerContainer.SparkConf.buildFor(sparkConfig, getContainerProperties())
diff --git a/amoro-ams/src/main/java/org/apache/amoro/server/table/RuntimeHandlerChain.java b/amoro-ams/src/main/java/org/apache/amoro/server/table/RuntimeHandlerChain.java
index 148d03d76..12230707a 100644
--- a/amoro-ams/src/main/java/org/apache/amoro/server/table/RuntimeHandlerChain.java
+++ b/amoro-ams/src/main/java/org/apache/amoro/server/table/RuntimeHandlerChain.java
@@ -43,7 +43,7 @@ public abstract class RuntimeHandlerChain {
     Preconditions.checkNotNull(handler);
     Preconditions.checkArgument(
         !Objects.equals(handler, this),
-        "Cannot add the same runtime handler:{} twice",
+        "Cannot add the same runtime handler:%s twice",
         handler.getClass().getSimpleName());
     if (next == null) {
       next = handler;
diff --git a/amoro-format-hudi/src/main/java/org/apache/amoro/formats/hudi/HudiHadoopCatalog.java b/amoro-format-hudi/src/main/java/org/apache/amoro/formats/hudi/HudiHadoopCatalog.java
index 6dbcff008..1e2d81011 100644
--- a/amoro-format-hudi/src/main/java/org/apache/amoro/formats/hudi/HudiHadoopCatalog.java
+++ b/amoro-format-hudi/src/main/java/org/apache/amoro/formats/hudi/HudiHadoopCatalog.java
@@ -61,7 +61,7 @@ public class HudiHadoopCatalog implements FormatCatalog {
 
     Preconditions.checkArgument(
         this.properties.containsKey(CatalogMetaProperties.KEY_WAREHOUSE),
-        "Lack required property: {}",
+        "Lack required property: %s",
         CatalogMetaProperties.KEY_WAREHOUSE);
     String warehouse = this.properties.get(CatalogMetaProperties.KEY_WAREHOUSE);
     this.warehouse = new Path(warehouse);