You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/04 05:04:28 UTC
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Hello Adar Dembo, Bankim Bhavsar, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15651
to review the following change.
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
scripts: fix benchmark parsing for wire_protocol-test
This fixes the existing parsing for row-wise conversion, and adds
parsing for the new columnar conversion, writing the columnar stats as a
new workload "WireProtocolBenchmark_columnar" and plotting results as
"wire-protocol-test_columnar".
Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/15651/1
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Bankim Bhavsar, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15651
to look at the new patch set (#2).
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
scripts: fix benchmark parsing for wire_protocol-test
This fixes the existing parsing for row-wise conversion, and adds
parsing for the new columnar conversion, writing the columnar stats as a
new workload "WireProtocolBenchmark_columnar" and plotting results as
"wire-protocol-test_columnar".
Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/15651/2
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15651 )
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15651/1/src/kudu/scripts/benchmarks.sh
File src/kudu/scripts/benchmarks.sh:
http://gerrit.cloudera.org:8080/#/c/15651/1/src/kudu/scripts/benchmarks.sh@221
PS1, Line 221:
> Nit: 100 percent?
Done, though I rephrased instead
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 04 Apr 2020 18:53:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15651 )
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15651/1/src/kudu/scripts/benchmarks.sh
File src/kudu/scripts/benchmarks.sh:
http://gerrit.cloudera.org:8080/#/c/15651/1/src/kudu/scripts/benchmarks.sh@221
PS1, Line 221: 1
Nit: 100 percent?
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 04 Apr 2020 05:38:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15651 )
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
Patch Set 1: Code-Review+2
Thank you for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 04 Apr 2020 16:40:45 +0000
Gerrit-HasComments: No
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15651 )
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
scripts: fix benchmark parsing for wire_protocol-test
This fixes the existing parsing for row-wise conversion, and adds
parsing for the new columnar conversion, writing the columnar stats as a
new workload "WireProtocolBenchmark_columnar" and plotting results as
"wire-protocol-test_columnar".
Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Reviewed-on: http://gerrit.cloudera.org:8080/15651
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 16 insertions(+), 10 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] scripts: fix benchmark parsing for wire protocol-test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15651 )
Change subject: scripts: fix benchmark parsing for wire_protocol-test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1ac45cf730674a4aa3b7d1f7f60b6919e3eeb1
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 04 Apr 2020 20:19:22 +0000
Gerrit-HasComments: No