You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/09 16:29:31 UTC
[GitHub] [dubbo-go-hessian2] lujjjh opened a new pull request #255: Fix #253: Acquire sufficient bytes for string encoding buffers
lujjjh opened a new pull request #255:
URL: https://github.com/apache/dubbo-go-hessian2/pull/255
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Acquire sufficient bytes for string encoding buffers.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #253
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
- fix index out of range in some string encoding cases
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #255: Fix #253: Acquire sufficient bytes for string encoding buffers
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #255:
URL: https://github.com/apache/dubbo-go-hessian2/pull/255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #255: Fix #253: Acquire sufficient bytes for string encoding buffers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #255:
URL: https://github.com/apache/dubbo-go-hessian2/pull/255#issuecomment-757331555
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=desc) (0b4c6a8) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/ab7254f3a2cf69cda8d3878fb16489b051ef707a?el=desc) (ab7254f) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 25 25
Lines 2671 2671
=======================================
Hits 1806 1806
Misses 644 644
Partials 221 221
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `70.70% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=footer). Last update [ab7254f...0b4c6a8](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #255: Fix #253: Acquire sufficient bytes for string encoding buffers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #255:
URL: https://github.com/apache/dubbo-go-hessian2/pull/255#issuecomment-757331555
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=desc) (0b4c6a8) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/ab7254f3a2cf69cda8d3878fb16489b051ef707a?el=desc) (ab7254f) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 25 25
Lines 2671 2671
=======================================
Hits 1806 1806
Misses 644 644
Partials 221 221
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `70.70% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=footer). Last update [ab7254f...0b4c6a8](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-io commented on pull request #255: Fix #253: Acquire sufficient bytes for string encoding buffers
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #255:
URL: https://github.com/apache/dubbo-go-hessian2/pull/255#issuecomment-757331555
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=desc) (0b4c6a8) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/ab7254f3a2cf69cda8d3878fb16489b051ef707a?el=desc) (ab7254f) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 25 25
Lines 2671 2671
=======================================
Hits 1806 1806
Misses 644 644
Partials 221 221
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `70.70% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=footer). Last update [ab7254f...0b4c6a8](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-io commented on pull request #255: Fix #253: Acquire sufficient bytes for string encoding buffers
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #255:
URL: https://github.com/apache/dubbo-go-hessian2/pull/255#issuecomment-757331555
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=desc) (0b4c6a8) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/ab7254f3a2cf69cda8d3878fb16489b051ef707a?el=desc) (ab7254f) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 25 25
Lines 2671 2671
=======================================
Hits 1806 1806
Misses 644 644
Partials 221 221
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `70.70% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=footer). Last update [ab7254f...0b4c6a8](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org