You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/28 15:22:22 UTC
[GitHub] [kafka] ijuma opened a new pull request, #13051: MINOR: Call LogConfig.validate instead of validateValues in `KafkaMetadataLog`
ijuma opened a new pull request, #13051:
URL: https://github.com/apache/kafka/pull/13051
The former may fail or return misleading results if the properties don't include defaults.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13051: MINOR: Use `LogConfig.validate` instead of `validateValues` in `KafkaMetadataLog`
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13051:
URL: https://github.com/apache/kafka/pull/13051#issuecomment-1366844162
JDK 17 build passed, the other failures are unrelated:
> Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
> Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplicationWithEmptyPartition()
> Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[exactly_once]
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13051: MINOR: Use `LogConfig.validate` instead of `validateValues` in `KafkaMetadataLog`
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13051:
URL: https://github.com/apache/kafka/pull/13051#issuecomment-1366843677
@jsancio Yes, right - this preempts a potential issue if KRaft starts using some of the other properties. This fix also means we don't need to add a workaround in the PR that moves LogConfig to Java (an NPE happens without a workaround since the semantics of unboxing are different for Java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #13051: MINOR: Use `LogConfig.validate` instead of `validateValues` in `KafkaMetadataLog`
Posted by GitBox <gi...@apache.org>.
ijuma merged PR #13051:
URL: https://github.com/apache/kafka/pull/13051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org