You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "lie18uci (via GitHub)" <gi...@apache.org> on 2026/06/12 00:37:57 UTC
[PR] fix(storage): close Files.walk stream in deleteRepo [texera]
lie18uci opened a new pull request, #5633:
URL: https://github.com/apache/texera/pull/5633
### What changes were proposed in this PR?
This PR updates GitVersionControlLocalFileStorage.deleteRepo to close the stream returned by Files.walk(directoryPath) using try-with-resources.
Files.walk(...) returns a closeable stream backed by directory resources. Wrapping it in try-with-resources ensures the stream is closed properly even if traversal or deletion throws.
This keeps the existing deletion behavior unchanged while fixing the stream lifecycle.
### Any related issues, documentation, discussions?
Closes #5548
### How was this PR tested?
Verified the code change locally by inspecting the diff.
Attempted to run:
sbt "scalafixAll --check"
but the local check failed because jOOQ code generation could not complete in my local setup. The error was:
JOOQ code generation failed: FATAL: role "postgres" does not exist
This caused unrelated compile errors for missing org.apache.texera.dao.jooq.generated classes.
No new tests were added because this is a single-method resource lifecycle fix and existing dataset deletion paths already exercise this code.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5633:
URL: https://github.com/apache/texera/pull/5633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #5633:
URL: https://github.com/apache/texera/pull/5633#issuecomment-4687633647
@xuang7 shall we backport this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5633:
URL: https://github.com/apache/texera/pull/5633#issuecomment-4689344739
Backport to [`release/v1.2`](https://github.com/apache/texera/tree/release/v1.2) succeeded as [`118877f`](https://github.com/apache/texera/commit/118877f0217975ca8d45bf40553efc6f9c85a165). [Run](https://github.com/apache/texera/actions/runs/27405734647)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo [texera]
Posted by "lie18uci (via GitHub)" <gi...@apache.org>.
lie18uci commented on PR #5633:
URL: https://github.com/apache/texera/pull/5633#issuecomment-4687933502
> @lie18uci thanks for the fix. Could you please add tests to guard the change?
Thank you for the review. I added `GitVersionControlLocalFileStorageSpec`, which creates a temporary nested repository directory, calls `deleteRepo`, and verifies that the repository directory is deleted recursively.
I also ran `sbt scalafmtCheckAll` locally successfully. My local targeted test run is still blocked by jOOQ/PostgreSQL setup because PostgreSQL is not running on `localhost:5432`, so I am relying on GitHub CI for the backend test run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5633:
URL: https://github.com/apache/texera/pull/5633#issuecomment-4686944634
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5633?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 52.54%. Comparing base ([`39a1234`](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`17d4f72`](https://app.codecov.io/gh/apache/texera/commit/17d4f72e54e901cb9d600288f5f681eee5464ad8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5633 +/- ##
=========================================
Coverage 52.54% 52.54%
Complexity 2485 2485
=========================================
Files 1071 1071
Lines 41363 41359 -4
Branches 4441 4441
=========================================
Hits 21733 21733
+ Misses 18357 18353 -4
Partials 1273 1273
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.61% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.31% <ø> (+0.01%)` | :arrow_up: | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.71% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.17% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.72% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.75% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [39a1234](https://app.codecov.io/gh/apache/texera/commit/39a12345a50292c3b047b7a44f8848a7c7102d8a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5633?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5633:
URL: https://github.com/apache/texera/pull/5633#issuecomment-4686948185
<!-- texera-benchmarks-comment -->
## Arrow Flight E2E bench
| batch | schema_w | str_len | n_batches | tuples/s | MB/s | p50 ms | p99 ms | total ms |
|---:|---:|---:|---:|---:|---:|---:|---:|---:|
| 10 | 10 | 64 | 20 | 536 | 0.327 | 18.43 | 26.96 | 372.93 |
| 100 | 10 | 64 | 20 | 1208 | 0.737 | 82.20 | 102.00 | 1656.27 |
| 1000 | 10 | 64 | 20 | 1404 | 0.857 | 711.41 | 753.80 | 14240.33 |
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,372.93,200,128000,536,0.327,18428.71,26956.47,26956.47
1,100,10,64,20,1656.27,2000,1280000,1208,0.737,82199.19,101996.52,101996.52
2,1000,10,64,20,14240.33,20000,12800000,1404,0.857,711413.58,753803.30,753803.30
```
</details>
[Full workflow run](https://github.com/apache/texera/actions/runs/27386707510)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org