You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/20 03:34:20 UTC
Re: [PR] fix(reports): propagate force flag to dashboard permalink report URLs [superset]
rusackas commented on PR #38691:
URL: https://github.com/apache/superset/pull/38691#issuecomment-5018521784
@ferjanin still conflicting with master, and the dedup ask from March never landed. `force = "true" if self._report_schedule.force_screenshot else "false"` in `_get_url` (superset/commands/report/execute.py) is now computed a second time, verbatim, in `_get_tab_url`. Worth pulling into one helper (or just passing it down from `_get_url`) before this merges. I'll see if I can help with a rebase here to start...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org