You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by ka...@apache.org on 2021/07/08 16:43:02 UTC
[submarine] branch master updated: SUBMARINE-914. Github Action
compiles Docker images twice
This is an automated email from the ASF dual-hosted git repository.
kaihsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 700e471 SUBMARINE-914. Github Action compiles Docker images twice
700e471 is described below
commit 700e47129bdba4f8fe154d3d6c1fc995105eb6c7
Author: Kai-Hsun Chen <b0...@ntu.edu.tw>
AuthorDate: Thu Jul 8 18:36:47 2021 +0800
SUBMARINE-914. Github Action compiles Docker images twice
### What is this PR for?
Github Action compiles Docker images twice.
1st: "Build image locally"
https://github.com/apache/submarine/blob/master/.github/workflows/master.yml#L158
2nd: "Test"
https://github.com/apache/submarine/blob/master/.github/workflows/master.yml#L170
Because of the [pom.xml](https://github.com/apache/submarine/blob/master/submarine-test/test-k8s/pom.xml#L155), the script "integration-test.sh" with the argument "--update"
will compile all images again.
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-914#
### How should this be tested?
* Github Action: check if all test cases in "submarine-k8s" are executed as expected.
### Screenshots (if appropriate)
<img width="1395" alt="ζͺε 2021-07-08 δΈε6 13 06" src="https://user-images.githubusercontent.com/20109646/124906336-8c71bb00-e019-11eb-83ef-874c1932f3fe.png">
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: Kai-Hsun Chen <b0...@ntu.edu.tw>
Signed-off-by: Kai-Hsun Chen <ka...@apache.org>
Closes #656 from kevin85421/test and squashes the following commits:
7f2c5b98 [Kai-Hsun Chen] Fix
b0e707c3 [Kai-Hsun Chen] test
---
submarine-test/test-k8s/pom.xml | 31 -------------------------------
1 file changed, 31 deletions(-)
diff --git a/submarine-test/test-k8s/pom.xml b/submarine-test/test-k8s/pom.xml
index 512cbaa..96a2db5 100644
--- a/submarine-test/test-k8s/pom.xml
+++ b/submarine-test/test-k8s/pom.xml
@@ -146,37 +146,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
- <executions>
- <execution>
- <id>start-integration-ks8-test</id>
- <phase>pre-integration-test</phase>
- <configuration>
- <target unless="skipTests">
- <exec executable="./integration-test.sh" dir="${submarine.cloud.path}" spawn="false">
- <arg value="--start"/>
- <arg value="--update"/>
- </exec>
- </target>
- </configuration>
- <goals>
- <goal>run</goal>
- </goals>
- </execution>
- <execution>
- <id>stop-integration-ks8-test</id>
- <phase>post-integration-test</phase>
- <configuration>
- <target unless="skipTests">
- <exec executable="./integration-test.sh" dir="${submarine.cloud.path}" spawn="false">
- <arg value="--stop"/>
- </exec>
- </target>
- </configuration>
- <goals>
- <goal>run</goal>
- </goals>
- </execution>
- </executions>
</plugin>
</plugins>
</build>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org