You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mike Dillon (JIRA)" <ji...@codehaus.org> on 2009/09/10 21:53:31 UTC
[jira] Commented: (MRELEASE-477) Add a commitBeforeTag option for
release:prepare to allow skipping scm-commit-release
[ http://jira.codehaus.org/browse/MRELEASE-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=190542#action_190542 ]
Mike Dillon commented on MRELEASE-477:
--------------------------------------
Just wanted to see if anyone had a chance to look at this issue. I have a patch locally that I've been using successfully for the past few weeks. It would be great if the fix could get into a released version of the plugin; I really don't want to have to think about forking the plugin.
> Add a commitBeforeTag option for release:prepare to allow skipping scm-commit-release
> -------------------------------------------------------------------------------------
>
> Key: MRELEASE-477
> URL: http://jira.codehaus.org/browse/MRELEASE-477
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Components: prepare
> Reporter: Mike Dillon
>
> As detailed in this thread, there can be reproducibility problems with committing to the source branch (e.g. trunk) before tagging:
> http://www.nabble.com/Limitation-of-the-release-plugin--to20822478.html
> In the now default case where remoteTagging is true, the commit to the source branch is necessary to get the source into the right state before doing the remote copy. However, when remoteTagging is false, the extra commit means that between the user's initial checkout and the automatic commit to the source branch, other changes could have been committed which will mean that the new tag will not have been created from a single, consistent revision of the source branch.
> My proposed fix for this is to add a commitBeforeTag option that would cause scm-commit-release to be skipped during release:prepare. It would be an error to have commitBeforeTag=false when remoteTagging=true since the commit before tag must be done in the remote tagging scenario.
> I can provide a patch if this approach is acceptable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira