You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2011/07/13 06:58:59 UTC

[jira] [Created] (LUCENE-3308) Cleanup 'good' queries code

Cleanup 'good' queries code
---------------------------

                 Key: LUCENE-3308
                 URL: https://issues.apache.org/jira/browse/LUCENE-3308
             Project: Lucene - Java
          Issue Type: Sub-task
            Reporter: Chris Male


Before moving some of the classes from the queries contrib to the queries module, I want to just pass over them and clean them up, since we want code in modules to be of the same calibre as core code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3308) Cleanup 'good' queries code

Posted by "Chris Male (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Male resolved LUCENE-3308.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

Committed revision 1145916.

> Cleanup 'good' queries code
> ---------------------------
>
>                 Key: LUCENE-3308
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3308
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-3308.patch, LUCENE-3308.patch
>
>
> Before moving some of the classes from the queries contrib to the queries module, I want to just pass over them and clean them up, since we want code in modules to be of the same calibre as core code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3308) Cleanup 'good' queries code

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064376#comment-13064376 ] 

Simon Willnauer commented on LUCENE-3308:
-----------------------------------------

bq. Tests pass. Ready to go.
+1

> Cleanup 'good' queries code
> ---------------------------
>
>                 Key: LUCENE-3308
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3308
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Chris Male
>         Attachments: LUCENE-3308.patch
>
>
> Before moving some of the classes from the queries contrib to the queries module, I want to just pass over them and clean them up, since we want code in modules to be of the same calibre as core code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Assigned] (LUCENE-3308) Cleanup 'good' queries code

Posted by "Chris Male (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Male reassigned LUCENE-3308:
----------------------------------

    Assignee: Chris Male

> Cleanup 'good' queries code
> ---------------------------
>
>                 Key: LUCENE-3308
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3308
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Chris Male
>            Assignee: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-3308.patch, LUCENE-3308.patch
>
>
> Before moving some of the classes from the queries contrib to the queries module, I want to just pass over them and clean them up, since we want code in modules to be of the same calibre as core code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3308) Cleanup 'good' queries code

Posted by "Chris Male (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Male updated LUCENE-3308:
-------------------------------

    Attachment: LUCENE-3308.patch

Improved patch.

> Cleanup 'good' queries code
> ---------------------------
>
>                 Key: LUCENE-3308
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3308
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Chris Male
>         Attachments: LUCENE-3308.patch, LUCENE-3308.patch
>
>
> Before moving some of the classes from the queries contrib to the queries module, I want to just pass over them and clean them up, since we want code in modules to be of the same calibre as core code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3308) Cleanup 'good' queries code

Posted by "Chris Male (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Male updated LUCENE-3308:
-------------------------------

    Attachment: LUCENE-3308.patch

Patch which fixes indentation, moves over to Java 5 loops, cleans up some comparisons, and leaves a TODO in TermsFilter for future work.

Tests pass.  Ready to go.

> Cleanup 'good' queries code
> ---------------------------
>
>                 Key: LUCENE-3308
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3308
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Chris Male
>         Attachments: LUCENE-3308.patch
>
>
> Before moving some of the classes from the queries contrib to the queries module, I want to just pass over them and clean them up, since we want code in modules to be of the same calibre as core code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org