You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/06/29 19:04:24 UTC
[Apache Bloodhound] #121: Remove Back to Roadmap link from
Milestone pages when Roadmap is disabled
#121: Remove Back to Roadmap link from Milestone pages when Roadmap is disabled
-----------------------+-------------------------------------
Reporter: gjm | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone: RC1 for initial release
Component: trac core | Version:
Keywords: |
-----------------------+-------------------------------------
If the Roadmap module is not activated, there is no reason for a Milestone
to show a link back to the missing Roadmap page.
Is this due to anything we have done?
Something like this would fix it:
{{{
#!diff
Index: trac/ticket/roadmap.py
===================================================================
--- trac/ticket/roadmap.py (revision 1353999)
+++ trac/ticket/roadmap.py (working copy)
@@ -886,8 +886,9 @@
if idx < len(milestones) - 1:
add_milestone_link('next', milestones[idx + 1])
add_milestone_link('last', milestones[-1])
+ roadmap_back = self.env[RoadmapModule] and _('Back to Roadmap')
or None
prevnext_nav(req, _('Previous Milestone'), _('Next Milestone'),
- _('Back to Roadmap'))
+ roadmap_back)
return 'milestone_view.html', data, None
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/121>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #121: Remove Back to Roadmap link from
Milestone pages when Roadmap is disabled
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#121: Remove Back to Roadmap link from Milestone pages when Roadmap is disabled
------------------------+-------------------------------------
Reporter: gjm | Owner: gjm
Type: defect | Status: closed
Priority: major | Milestone: RC1 for initial release
Component: trac core | Version:
Resolution: fixed | Keywords:
------------------------+-------------------------------------
Changes (by gjm):
* status: accepted => closed
* resolution: => fixed
Comment:
r1359227 applies the fix
We might have a case for providing an alternative link for Bloodhound and
Trac might consider a different approach so this may be worth keeping an
eye on.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/121#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #121: Remove Back to Roadmap link from
Milestone pages when Roadmap is disabled
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#121: Remove Back to Roadmap link from Milestone pages when Roadmap is disabled
------------------------+-------------------------------------
Reporter: gjm | Owner: gjm
Type: defect | Status: accepted
Priority: major | Milestone: RC1 for initial release
Component: trac core | Version:
Resolution: | Keywords:
------------------------+-------------------------------------
Changes (by gjm):
* owner: nobody => gjm
* status: new => accepted
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/121#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker