You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/06 05:37:47 UTC

[GitHub] codecov-io commented on issue #5830: Get 'Test Connection' button to take 'engine_params' into account

codecov-io commented on issue #5830: Get 'Test Connection' button to take 'engine_params' into account
URL: https://github.com/apache/incubator-superset/pull/5830#issuecomment-418970487
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=h1) Report
   > Merging [#5830](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c2dbad803ad8747bb7af72889e48bf912cf78bb?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5830/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #5830      +/-   ##
   =========================================
   + Coverage    63.7%   63.7%   +<.01%     
   =========================================
     Files         366     366              
     Lines       23143   23144       +1     
     Branches     2599    2599              
   =========================================
   + Hits        14744   14745       +1     
     Misses       8384    8384              
     Partials       15      15
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5830/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.31% <100%> (+0.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=footer). Last update [8c2dbad...7555c27](https://codecov.io/gh/apache/incubator-superset/pull/5830?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org