You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "0xMudit (via GitHub)" <gi...@apache.org> on 2026/08/25 17:56:26 UTC

[I] docs(cli): Ctrl+T help says latest thinking block but the binding toggles all in view [maka]

0xMudit opened a new issue, #3826:
URL: https://github.com/apache/maka/issues/3826

   ## What happened
   
   `/help` documents Ctrl+T as *"expand or collapse **the latest** thinking block"* (`packages/cli/src/tui-primary-guidance.ts:127`; zh copy at line 79 says 最近的思考块). The binding actually calls `toggleAllThinkingExpansion` (`packages/cli/src/pi-tui-runner.ts:3498`), which flips **every** thinking entry in the live viewport (`packages/cli/src/pi-transcript.ts:471-489`).
   
   With two or more thinking blocks in view, all of them toggle — not just the latest. This is exactly the drift `/help` claims to prevent: command copy is derived from the registry so it cannot drift, but keybinding copy is hand-written. The English line also reads inconsistently next to Ctrl+O's "expand or collapse **all** tool output".
   
   ## How to reproduce
   
   1. Run a session that produces two or more thinking blocks
   2. Press Ctrl+T with both in view — every thinking block toggles, while `/help` promised only the latest
   
   ## Suggested fix
   
   Reword both locales to match the handler ("expand or collapse all thinking in view", consistent with the Ctrl+O phrasing), or scope the handler to the most recent entry if "latest" was the intent. Rewording seems more likely correct given the function name and its #1134-style contract.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [I] docs(cli): Ctrl+T help says latest thinking block but the binding toggles all in view [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #3826: docs(cli): Ctrl+T help says latest thinking block but the binding toggles all in view
URL: https://github.com/apache/maka/issues/3826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org