You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/06/03 00:10:48 UTC

[GitHub] [guacamole-client] mike-jumper opened a new pull request #407: GUACAMOLE-805: Handle OpenID "id_token" parameter regardless of location in URL fragment.

mike-jumper opened a new pull request #407: GUACAMOLE-805: Handle OpenID "id_token" parameter regardless of location in URL fragment.
URL: https://github.com/apache/guacamole-client/pull/407
 
 
   These changes add more robust handling of the `id_token` parameter. The URL fragment is automatically reformatted from the format used by OpenID to the format used by AngularJS, regardless of the location of `id_token` within that fragment.
   
   The fragment is reformatted from `#...` to `#/?...` if all of the following are true:
   
   1. The fragment did not already start with `#/` (an AngularJS path).
   2. The fragment did not already start with `#?` (which AngularJS will already handle as a list of parameters).
   3. The fragment contains an `id_token` parameter, either at the beginning or elsewhere within the parameter list.
   
   All other fragments are left untouched.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services