You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/02/01 10:51:06 UTC
Review Request: [EC2 Query API] RunInstances allows negative values for
paramters 'MinCount' and 'MaxCount'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9243/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
Add parameter validation to ensure MinCount is greater than 0 and MaxCount is great than or equal to MinCount
This addresses bug CLOUDSTACK-1131.
Diffs
-----
awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f
awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6
Diff: https://reviews.apache.org/r/9243/diff/
Testing
-------
Run ec2_run_instances with negative value for either MinCount or MaxCount - 'InvalidParameterValue' error should be obtained
Thanks,
Likitha Shetty
Re: Review Request: [EC2 Query API] RunInstances allows negative values for
paramters 'MinCount' and 'MaxCount'
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9243/#review16484
-----------------------------------------------------------
Ship it!
Validation is ok.
Commit hash: 04a571e7ef350082c157f96d6ce7574c5b00d306
- Prachi Damle
On Feb. 1, 2013, 9:51 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9243/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 9:51 a.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> Add parameter validation to ensure MinCount is greater than 0 and MaxCount is great than or equal to MinCount
>
>
> This addresses bug CLOUDSTACK-1131.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f
> awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6
>
> Diff: https://reviews.apache.org/r/9243/diff/
>
>
> Testing
> -------
>
> Run ec2_run_instances with negative value for either MinCount or MaxCount - 'InvalidParameterValue' error should be obtained
>
>
> Thanks,
>
> Likitha Shetty
>
>