You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/24 17:55:39 UTC

[jira] Created: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

java client api does not allow client to access negotiated session timeout
--------------------------------------------------------------------------

                 Key: ZOOKEEPER-593
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
             Project: Zookeeper
          Issue Type: Bug
          Components: java client
            Reporter: Patrick Hunt
             Fix For: 3.3.0


The java client api does not allow the client to access the negotiated session timeout (c does allow this).

In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-593:
--------------------------------------

    Assignee: Patrick Hunt

> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804856#action_12804856 ] 

Mahadev konar commented on ZOOKEEPER-593:
-----------------------------------------

+1 the patch looks good.

> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-593.patch
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-593:
-----------------------------------

    Attachment: ZOOKEEPER-593.patch

Updated the java code/docs/tests with a new getSessionTimeout() method.

Also updated the c api documentation (method existed, just no doc, so I added doc exclusively)


> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-593.patch
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-593:
-----------------------------------

    Status: Patch Available  (was: Open)

> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-593.patch
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804044#action_12804044 ] 

Hadoop QA commented on ZOOKEEPER-593:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12431161/ZOOKEEPER-593.patch
  against trunk revision 902320.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/50/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/50/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/50/console

This message is automatically generated.

> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-593.patch
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805477#action_12805477 ] 

Hudson commented on ZOOKEEPER-593:
----------------------------------

Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/])
    

> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-593.patch
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-593:
------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. thanks pat. I need some time to write my own code (been spending a lot of time reviewing your code :)).

> java client api does not allow client to access negotiated session timeout
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-593
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-593.patch
>
>
> The java client api does not allow the client to access the negotiated session timeout (c does allow this).
> In some cases the client may not get the requested timeout (server applies a min/max bound) in which case
> the client user code may want to examine the timeout it did receive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.